refactor(connect-common): drop unused account.path from composePsbt params - #32182
Open
mroz22 wants to merge 1 commit into
Open
refactor(connect-common): drop unused account.path from composePsbt params#32182mroz22 wants to merge 1 commit into
mroz22 wants to merge 1 commit into
Conversation
…arams `ComposePsbtParams.account.path` was copied from composeTransaction's account shape, but composePsbt/parsePsbt never read it — every derivation path comes from the per-utxo and per-change-address entries. Rather than leave a required-but-unused (or optional-but-unused) field on the public API, drop it entirely so the type reflects exactly what the method consumes. The type-test literal is updated accordingly. (composeTransaction keeps its `path`, which it genuinely uses.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mroz22
added
the
no-project
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone extraction from the review of #26056 — a single self-contained commit, so it can be taken (or not) independently of the rest of the review follow-ups.
Change: remove
account.pathfromComposePsbtParamsentirely (and from the type-test literal).Why:
pathwas copied from composeTransaction's account shape, butcomposePsbt/parsePsbtnever read it — every derivation path comes from the per-utxo and per-change-address entries. Dropping it makes the public type reflect exactly what the method consumes. composeTransaction keeps itspath(which it genuinely uses), so the two account shapes correctly differ. Callers passing a full account variable are unaffected; only inline object literals that includepathneed it dropped.Type-check clean for
@trezor/connect-commonand@trezor/connect. Based onfeat/connect-psbt.🤖 Generated with Claude Code