Skip to content

fix(suite): do not show insufficient funds when yield tx is pending - #32179

Merged
TomasBoda merged 1 commit into
developfrom
fix/yield-pending-tx-insufficient-funds
Sep 8, 2026
Merged

fix(suite): do not show insufficient funds when yield tx is pending#32179
TomasBoda merged 1 commit into
developfrom
fix/yield-pending-tx-insufficient-funds

Conversation

@TomasBoda

@TomasBoda TomasBoda commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Do not show Insufficient funds warning banner in yield flow when transaction is pending.

Related Issue

Resolve #31880

Screenshots:

🤖 LLM Test Recommendations

Summary: The changes are confined to Earn/Yield UI components. Only the yield withdrawal flow has direct e2e coverage in the current suite. Run the two yield tests to validate YieldWithdrawForm changes. The deposit, wrap, and unwrap components have no direct e2e tests (the static mapping for YieldDepositForm is a broad/global dependency and does not represent behavioral coverage).

Changed files (4)
  • packages/suite/src/components/earn/yield/deposit/YieldDepositForm.tsx
  • packages/suite/src/components/earn/yield/unwrap/UnwrapNativeToken.tsx
  • packages/suite/src/components/earn/yield/withdraw/YieldWithdrawForm.tsx
  • packages/suite/src/components/earn/yield/wrap/WrapNativeToken.tsx

Recommended tests (2)

🔴 High priority (2)
  • suite/e2e/tests/yield/redeem.test.ts — This test directly exercises the yield redeem/withdraw flow from the earn dashboard, including the withdraw/redeem form and transaction simulation. Changes to YieldWithdrawForm.tsx could directly affect form validation, amount handling, or the review modal shown in this flow.
  • suite/e2e/tests/yield/withdrawal.test.ts — This test covers the full withdrawal flow from a USDC yield vault, including entering withdrawal amounts and confirming via the yield flow form. It is the most direct end-to-end coverage for YieldWithdrawForm.tsx.

⚠️ Changes with no test coverage (3)

  • packages/suite/src/components/earn/yield/deposit/YieldDepositForm.tsx
  • packages/suite/src/components/earn/yield/unwrap/UnwrapNativeToken.tsx
  • packages/suite/src/components/earn/yield/wrap/WrapNativeToken.tsx

Updated: 2026-09-07T11:42:29.342Z

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/fix/yield-pending-tx-insufficient-funds/web/

🔍 Currents Test Results

🔍 Suite web test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (web) — 5 test(s)
Test Type
Trading - Swap > Swap SOL USDT token to ETH 🤖 auto
Trading - Swap coin to token > Swap Solana to USDC 🤖 auto
Quarantine test: "TrezorConnect popup web,call cancelled from calling application" 🙋 manual
Quarantine test: "TrezorConnect webextension -> Suite Web,second call after popup was closed by user should work" 🙋 manual
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery" 🙋 manual

Updated: 2026-09-07T11:44:47.971Z • 5 test(s) total

Trezor Suite (desktop) — 2 test(s)
Test Type
Quarantine test: "Suite Sync - Quota Manager top-up,Exceeded wallet limit is topped up from the device pool" 🙋 manual
Trading - Swap > Swap SOL USDT token to ETH 🤖 auto

Updated: 2026-09-07T11:44:46.292Z • 2 test(s) total

@TomasBoda TomasBoda self-assigned this Sep 7, 2026
@TomasBoda
TomasBoda merged commit aeb2424 into develop Sep 8, 2026
30 checks passed
@TomasBoda
TomasBoda deleted the fix/yield-pending-tx-insufficient-funds branch September 8, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Never show not enough funds when yield tx is pending

2 participants