fix(suite): do not show insufficient funds when yield tx is pending - #32179
Merged
Conversation
tomasklim
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not show
Insufficient fundswarning banner in yield flow when transaction is pending.Related Issue
Resolve #31880
Screenshots:
🤖 LLM Test Recommendations
Summary: The changes are confined to Earn/Yield UI components. Only the yield withdrawal flow has direct e2e coverage in the current suite. Run the two yield tests to validate YieldWithdrawForm changes. The deposit, wrap, and unwrap components have no direct e2e tests (the static mapping for YieldDepositForm is a broad/global dependency and does not represent behavioral coverage).
Changed files (4)
packages/suite/src/components/earn/yield/deposit/YieldDepositForm.tsxpackages/suite/src/components/earn/yield/unwrap/UnwrapNativeToken.tsxpackages/suite/src/components/earn/yield/withdraw/YieldWithdrawForm.tsxpackages/suite/src/components/earn/yield/wrap/WrapNativeToken.tsxRecommended tests (2)
🔴 High priority (2)
suite/e2e/tests/yield/redeem.test.ts— This test directly exercises the yield redeem/withdraw flow from the earn dashboard, including the withdraw/redeem form and transaction simulation. Changes to YieldWithdrawForm.tsx could directly affect form validation, amount handling, or the review modal shown in this flow.suite/e2e/tests/yield/withdrawal.test.ts— This test covers the full withdrawal flow from a USDC yield vault, including entering withdrawal amounts and confirming via the yield flow form. It is the most direct end-to-end coverage for YieldWithdrawForm.tsx.packages/suite/src/components/earn/yield/deposit/YieldDepositForm.tsxpackages/suite/src/components/earn/yield/unwrap/UnwrapNativeToken.tsxpackages/suite/src/components/earn/yield/wrap/WrapNativeToken.tsxUpdated: 2026-09-07T11:42:29.342Z
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/fix/yield-pending-tx-insufficient-funds/web/
🔍 Currents Test Results
🔍 Suite web test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (web) — 5 test(s)
Updated: 2026-09-07T11:44:47.971Z • 5 test(s) total
Trezor Suite (desktop) — 2 test(s)
Updated: 2026-09-07T11:44:46.292Z • 2 test(s) total