Skip to content

fix: Update GeomSfPattern to more closely match GeomSf (#148)#152

Merged
trevorld merged 1 commit into
masterfrom
issue148
Jun 23, 2026
Merged

fix: Update GeomSfPattern to more closely match GeomSf (#148)#152
trevorld merged 1 commit into
masterfrom
issue148

Conversation

@trevorld

Copy link
Copy Markdown
Owner
  • Inherit use_defaults() and handle_na() from the updated GeomSf
  • Inline sf_grob() into draw_panel()
  • remove the now-unnecessary default_aesthetics() helper
  • add arrow.fill and translate_shape_string() constructor
  • set linetype = NULL

closes #148

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

* Inherit `use_defaults()` and `handle_na()` from the updated `GeomSf`
* Inline `sf_grob()` into `draw_panel()`
* remove the now-unnecessary `default_aesthetics()` helper
* add `arrow.fill` and `translate_shape_string()` constructor
* set `linetype = NULL`

closes #148

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@trevorld trevorld merged commit ac21e23 into master Jun 23, 2026
3 checks passed
@trevorld trevorld deleted the issue148 branch June 23, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update GeomSfPattern to more closely match GeomSf

1 participant