Persist QRZ credentials in platform secret stores - #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QRZ credentials were only held in process memory after setup. An engine restart, reboot, or rebuild required the operator to enter them again.
This change stores QRZ XML passwords and logbook API keys in the platform credential store. Windows uses Credential Manager. macOS uses Keychain. Linux uses Secret Service. The Rust and .NET engines use the same logical credential identifiers.
Runtime overrides and environment variables keep their documented precedence. The engine migrates legacy plaintext secrets and removes them from the shared TOML file. Credential read failures disable QRZ integration without blocking local logging. Credential write failures return FAILED_PRECONDITION.
The Settings view now shows whether each credential is configured. Empty secret fields preserve stored values and never load secret text into the UI.
The engine specification now defines persistence, precedence, platform mapping, migration, and error behavior.
Validation completed with the Release build, Rust formatting, Clippy, Rust tests, dependency audit, .NET engine tests, GUI tests, and the full .NET solution build.