Repository navigation
Use supported public scope in SDK golden reads - #405
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The SDK golden verifier currently appends --server and --team to every read. Library commands accept neither flag and proposal commands do not accept --team, so installed managed execution stops at valid public reads. Derive reader scope from the existing SDK command contract while preserving exact library refs, proposal project selection and team authority for workday/assignment/graph commands.
Work authority
23a4ccb38ee1cd5a45e6465d5ba42eab23472e082324fb2dea868822613162271f4ca3e3332830baContributor mode (select one):
Plan
Repair the concrete existing SDK verifier argument defect. One public command descriptor remains the command/scope authority; no copied command catalog, alternate runner or private-source fallback. Coordinate actual owning CLI native integration against this exact shipped SDK helper before counting the repair complete. This draft is a dependency candidate, not a new acceptance binding or SDK launch authorization.
Changes and commits
Verification
Node24.12.0 with retained development authority e4c4cad1e526f53d3549c8fc27c3e60122b20ee4:
node node_modules/vitest/vitest.mjs run --config ./vitest.contracts.config.ts tests/unit/operator-contracts/acceptance/golden-cli-arguments.test.ts tests/unit/operator-contracts/golden-product.test.ts tests/unit/operator-contracts/acceptance/golden-proposal-native.test.ts:22/22passed, zero failed/skipped/todo. The existing real SDK/native HTTP integration retains its original proof and denied observations; it does not prove actual CLI execution of the new scope helper.node node_modules/vitest/vitest.mjs run --config ./vitest.contracts.config.ts tests/contract/standards/package-archive.test.ts:6/6passed, zero failed/skipped/todo, retaining actual packed/installed public import closure. Strictnode node_modules/typescript/bin/tsc --noEmit, existing file length/architecture checks and git diff --check passed.Required Verify38164849288 succeeded on exact tested merge ac5b9ab/tree92ffbdf489e6143b09813a0e7e08bed12b33b02f: fresh584/584 SDK plus200/200 executing Reviewer e60ad2581e7ff041f058af04bd810796fea748f9 before249/249 component steps, zero failed/skipped/todo/diagnostics. Independent audit matches all249 actual assertion receipts and38 native Git source digests; selected archive helper/test bytes match original source. Report SHA256dbaa3823d5e382ef5255787bd4b235044620f8caef923ad302174b94087e3259; actual archive SHA256ff7a7af40bfce7398f137eabcbf9212f2e8d8f3ddb18c9f152df8b76fdb8c9e3. Scene artifact11712445391 ZIP9ea818d3648f3d1b2c9dff742ab4fc58c866b62d6102eb1959c1d2958e0320cd; package11711559793 ZIP126be56930ef0b12d8559873f18162b43e2190d73d8cfb7a6b0e53b7b3c8708f.
CLI297 consumes this actual verified archive in the existing public CLI native case. Focused native/metadata files14/14passed with all27denied observations retained, exact retry, source/installed-byte immutability and owned cleanup. Five positive reads plus20newdenials run concurrently in9149.720532ms within original30000ms; original7denials retained. Synthetic OS preload remains explicitly synthetic, controlled HTTP/session replies are not native API/model/host sealing proof. Initial sequential CLI CI failed before scenes (original30s deadline and missed held Reviewer pin test); failed observation preserved. ReplacementCLI38166667223 passed fresh369/369 CLI plus200/200 executing Reviewer tests before168/168 component steps. Independent archive audit reconciled all168 assertion receipts and33 native Git source digests; archive SHA256f7197cf8ffdf4f9cf6df158de234d26c92126f51ed71d17a155cea664a425dbe. Component-only native library assertions remain source proof, not installed managed verifier assets.
SDK owning source/native/artifact verification passes. Ordinary SDK staging merge and final installed composition read-back remain pending; no new binding credit or managed campaign.
Risk and rollback
The public command descriptor owns which reads use local operation/team scope. The verifier fails closed for mutation/unknown commands and repeated scope authority. An ordinary revert after fetching exact protected staging restores the prior reader while preserving RED and failed observations. No credentials, live runtime changes, releases, new environments or new worktrees.
Completion summary
Regression-first reader repair and required SDK complete/native/component verification pass. Actual archive consumed by original CLI native integration; paired CLI component verification passed; ordinary staging delivery and final integrated installed read-back pending. No criterion checked, managed run, SDK readiness or full acceptance claim.
Submission checklist