Repository navigation
Verify fixed SDK permission requests and Actor source custody - #404
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Prove exact SDK permission requests for criteria113–116 and retain their source authority in Actor graph nodes. The selected verifier previously accepted merely present requests and unrelated Actor permission fields.
Work authority
76275ae679c38a7e014de1f6d6f49449c820319e3683ef678bc78df292e0c81b06e9068bd71e9a29Contributor mode (select one):
Plan
Strengthen the existing SDK product gate and native public SDK verifier. Keep fixed SDK policy in SDK acceptance and generic grant compilation/inspection in its owning API/Agent boundaries. Agent must separately compare actual grants with the authored request before binding completion. No SDK src/product repair; genuine managed Tester→Reviewer→Engineer remains reserved.
Changes and commits
REDd0c45203 (17tests/16pass/1fail/0skip) reproduces incomplete fixed requests; RED2a317566 retains a substituted Actor permission request. Repair3b4217ea validates public canonical permission sets and exact seven content reads, Researcher/Architect content-write sets and Git/Releaser tool sets for all six original rows, preserving estimate-free drafts. Actual Actor graph requests must equal original authored requests. Generated Reviewer permissions remain governed by their distinct profile. Valid list permutations preserve inputs and pass; no allowance was narrowed or broadened.
Append3683ef67 retains permutation coverage and clones immutable native baseline inputs rather than serializing the same controlled YAML on every HTTP request. Fresh per-request mutation isolation remains; all original negative/transport cases and request counts are preserved. Measured focused native duration improved12247.8→6743.7ms inside the unchanged15s case/5s observation deadlines.
Existing native public SDK case adds54 role/request corruptions, concurrent exact reads, unchanged retry and retained failures. Original291proposal calls remain separately checked;171additional permission-read calls are exact. All21pair/21order denials and4transport cases remain. One necessary unit verifier joins the existing component scene; existing native/live IDs reused. No new runner/schema/role policy in shared runtime or manufactured managed proof.
Verification
Pinned Node24.12.0: focused21/21 unit/native/frozen-start tests,0failed/skipped/todo; strict TypeScript/file policies/diff checks pass. Initial strict inference errors were repaired with explicit types; checks remain enabled. Fresh Verify38150957176 passed580SDK+200executing Reviewer e60 assertions before all245component steps, zero failed/skipped/todo. Audited all245actual assertion receipts and37nativeGit sourcefiles against exact tested mergef006e0a0e507211d7d090d825ed19e1b26a27a31/tree3e01a755b19ef5319dc70296201e7fae0ac46d31. Report SHA35caa14ee1cd53a1c2bd9cafe5f7b25491d75cf23a80036f3ef3042c216b788c; CI archive633faeebd6a29f3c0318478ed2733de9384602e56f2d27333e419e4a83543bf8. SceneZIP11706712971 SHA3e1cea11d085a3fda012ac37ad5c651e1cbd66d2fee227772cc5f65b2c2b9fa2; packageZIP11706981569 SHA54998eb3312edb1a1776466ecd052d60f16b34af40a563bf408eae5eb53b99bf. All changed shipped assets match native Git. Actual six-owner archives installed production-only/scripts disabled, source and installed strictplan byte-identical SHAca18b6a201afa750e1251cd981e044417169ba4dfd10b0018d8fb52636cb9944:52mapped/152uncovered/204selected/260deferred, only uncovered diagnostics; expectedexit1 remains blocked. Installed node_modules removed; held exact heads/archives unchanged. No local scene or reused prerequisite receipt. Agent413 native delivery and staging composition remain pending.
Risk and rollback
Stricter guards may expose malformed current governed requests previously accepted by presence checks. Retain failure evidence and repair earliest owner after focused RED. Ordinary revert retains test-first history.
Completion summary
113–116 remain unchecked pending actual grant-intersection proof, exact native verification, delivery and installed composition. Checklist20completed/157open. No managed pass or launch readiness.
Submission checklist