Repository navigation
Verify exact authored SDK Actor and generated Reviewer graph pairs - #402
Merged
Merged
Conversation
Criterion170 regression: original product verifier accepts six counted pairs after a Reviewer is substituted with an unrelated work item. Baseline passes, mutation remains unchanged, expected denial is absent. Node24.12 unit15/14/1; retain RED before verifier repair. SDK product source remains untouched.
Retain original raw proposal and fixed draft assertions; compare complete public workday graph against each authored row, exact source and generated reviewer authority. Extend existing native SDK HTTP case with20 graph corruptions, concurrent reads,403/503/malformed/interrupted errors and unchanged retry; keep original5s/15s bounds and finally cleanup. Preserve unrelated workday nodes. Unit15, native16 and broader26 pass; strict tsc/file policies pass. Retain initial oversized-boundary fixture failure and exact correction. Add only necessary unit component selection; selected SDK live asset uses supported public graph read-back. No SDK product source change.
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Reject counted Actor/Reviewer pairs that do not represent the exact six authored SDK proposal work items. The existing SDK live verifier reads the public graph independently, checks each pair's authored/generated authority and exact proposal source, then confirms graph read-back stays unchanged.
Work authority
6d6749cd8c2676c6c50c009b55025ec3b951589db602440f63b76ba021159f20; unchecked semantic completiond2d56a6e59d1cdc036341b246c9f6fdf68cd52744a0e40be821bed57c44c623ebf21b4ac70ba4e4cContributor mode (select one):
Plan
Strengthen the original SDK verifier and native public SDK case; keep all selected/deferred identities and original deadlines. Integrator will add the SDK product reference to existing170 after adequate native producer proof and exact delivery. No SDK src change; the non-enumerable retired-field product defect remains reserved for genuine managed Tester→Reviewer→Engineer. No new authority, graph model, runner, production dispatch or role configuration.
Changes and commits
Verification
Pinned Node24.12.0. Original commands:
node node_modules/vitest/vitest.mjs run --config ./vitest.contracts.config.tsplus exact owning unit/native files and JSON reports: final16/16, zero failed/pending. Broader operator acceptance plus actual packed-archive contracts26/26. Strictnode node_modules/typescript/bin/tsc --noEmitandnpm run check:file-lengthspass. No local scene or managed campaign launched. Reports and failed observations retained in existing native verification cache; Actions artifacts remain verification authority.Required Verify38141158408 passed on exact tested mergea8a0ce0708a0ac8a0011cca20386bdfd1c8ece9b, base d2d56a6/source4a0e40be821bed57c44c623ebf21b4ac70ba4e4c/tree5ecf38bfeb8ab2bbf5ffb1ebf3c5af2b48b4db4d. Fresh complete suites578SDK+200executingReviewer(e60ad2581e7ff041f058af04bd810796fea748f9), zero failed/skipped/todo, preceded243componentsteps. All243 independent assertion receipts/37 owning source file digests/selected archive bytes audited against exact tested Git. ReportSHA64426a5d420a65ef10200f62f5ce8933025c4b653f8b1a505a56b819a2b3ae8c; CIarchiveSHA9e39698134efeaf5f6cb5cd8d953ab89202f1bfbdc27488d37bd701e0b497ec5. Sceneartifact11702604683 ZIP2325574226377b92f61baa040ee9f456ce46a4e0fe615777081f526897a79d99; packageartifact11703585328 ZIP09ae9b38cf3f9bc30f18664a1f3f218f8fde692c1b974fabb1da8cabd7f865ba.
Actual six-owner exact archives installed production-only/scripts-disabled. SDK archiveSHAe09dd55a0c9aa70c89e938b3b7e8ad58983c7cce8a51a27591330d884873525c. All six held candidates/cleanliness/archive digests and selected assets matched; source/installed strict plan bytes identical SHA64276f10148ddc227c699c068a64fed346f212a330a056e28a90a04c401423b8,47mapped/157uncovered/204selected/260deferred. Original stale previous-SHA script failure is retained: new unit registry entry was the sole plan change; final immutable audit passed without repeating installation. New Agent412 binding candidate also installed successfully (SHA5aee1bc93ca782bc7dc81d30bd8afbe8b9ac8869d3402470e026326dac068561). Both dependency trees and all owned subprocesses were cleaned. Ordinary staging read-back remains required. These are component/installed plan proofs, not native six-pair producer or managed receipts; earlier prerequisites cannot satisfy a future invocation.
Risk and rollback
Incomplete/mismatched public graph now fails the existing SDK verifier even if proposal and release receipts agree. Ordinary revert of repair restores prior verifier; preserve RED/history and failed observations. No product/API/database schema change or deadline relaxation.
Completion summary
This strengthens original partial170; it is not one of the177 originally unbound checklist rows and is not yet completed. Checklist18completed/159open. Agent411 delivered criterion169 wiring (formal47mapped/157uncovered), but API533 native prerequisites and final combined read-back still block169 completion. No current governed campaign authority, launch readiness or managed pass is claimed.
Submission checklist