Repository navigation
Repair SDK scene library readback and populated proposal proof - #399
Merged
Merged
Conversation
…opulated proposal references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The selected SDK scene consumes the actual supported CLI library-read envelope, then independently resolves its frozen project/team objective references and closed proposal discussion. The general SDK content schema remains unchanged; golden acceptance has stronger populated-proposal obligations.
Work authority
ee76efb086d5788323560fc74571c0b15ed58204d764f0a55d9463eb46f5b2ca811f2743d603a546Contributor mode (select one):
Plan
Retain the approved204selected/260deferred identities and existing SDK product verifier. Reproduce incomplete populated proposal acceptance and the supported CLI envelope mismatch before their fixes. Resolve exact original bytes through public owning reads, retain immutable failed observations and retry, then require fresh complete SDK/Reviewer suites before component scenes, actual installed archives and ordinary staging read-back. No campaign is launched.
Changes and commits
2965e8228722d7cf7b2348a900ad7ab3e86de619: populated proposal RED,11tests/10passed/1failed,0pending. Coherent issued digest did not reject draft/discussing or missing objective/discussion authority.3aa16e7d: same selected verifier validates actual ready status, frozen objective references, independently read project/team objectives and closed discussion bytes, digest, model, ID, subject, project and team ownership.b5f436bcd8c88cfc4289b02dd279e78bdd6705d6: CLI envelope RED after extracting the existing scene expression unchanged,12tests/11passed/1failed,0pending.8f099590efc3b94041f17d9271ed6c6c7859b3bd: consume the original CLI{result,receipt}envelope, reject source/raw-SDK fallback, wire original Team Library/reference reads into the same managed scene and reread observations unchanged.f5f50853ea8de1ca691c3dfc676a7303c42d4bee: coherent foreign closed-discussion subject RED,14tests/13passed/1failed,0pending; both repository and path substitutions passed the prior helper.d764f0a55d9463eb46f5b2ca811f2743d603a546: require discussion subject repository/path to match the exact original proposal and add native coherently rehashed denials/unchanged retry. Superseded own verification38127678731 was cancelled after replacing the candidate; its observations remain historical, not prerequisite evidence.ca901a709cb998ce8026671880aa28834695e0e3. Five existing acceptance/test files only; no SDK product source/schema change, new verifier ID, receipt resource or altered deadline.Verification
A real supported read-only
trsd library read sdk books/sdk-core.md --ref f3146757b664cfb74c6c376c12f3b7efa43b6ae4 --jsonconfirmed the actual envelope; its result contains nativeresultplus owningreceipt. The old selected scene usedcontent.data ?? content, so valid file data was never reached. Earlier direct-SDK tests did not exercise that CLI envelope consumer; eleven dependent checklist rows were reopened explicitly in SDK#393.Pinned Node24.12.0 focused command:
node node_modules/vitest/vitest.mjs run --config vitest.contracts.config.ts tests/unit/operator-contracts/golden-product.test.ts tests/unit/operator-contracts/acceptance/golden-proposal-native.test.ts tests/unit/operator-contracts/acceptance/workday-start.test.ts --reporter=json --outputFile=<retained-json>:18/18passed,0failed/pending. Build and file/architecture checks passed.Original native HTTP→SDK→isolated verifier exercises actual project, Team Library and reference file operations plus the selected envelope consumer using controlled CLI-shaped frames. This is SDK consumer/transport proof, not execution of the compiled CLI or genuine API-governed model results. Preserve original47denied/150request checks; extended native test retains59denied observations/189original proposal requests plus separately retained reference requests, then unchanged retry. A coherently rehashed open discussion is rejected. Original5second/15second watchdogs retained; listener/worker/input directory close in finally. Unit tests retain missing/duplicate/moved/foreign/raw-byte/frontmatter/read-inventory denials and unchanged retry.
Required Actions38128291057 passed on tested merge
983cba783bcc65d65965870886f2ffca2c7d198f, treeca901a709cb998ce8026671880aa28834695e0e3: fresh577/577SDK and200/200executingReviewer assertions before241/241component steps, zero failed/skipped/todo prerequisites or diagnostics. Independent artifact audit checks every241assertion receipts, all37source-file digests against native Git, and both shipped acceptance assets. Report SHA256bb8d5d038a8e148c9e065d3b38746ed5dbe78e79e85c6440a7dac4acefc2fd42; CI archivee4cf32dd9dd1e8a364dc0658b49355711dbee377bc2eee13c0f09d8a80861769; scene ZIP52f8e813151b1301bf7cb958d24f262f9ef019310c8de9bde7241df06d51af93; package ZIPd3f3660ee71e4cd92964c32732e36b4948df6596288cc0c2f05a87fbceda22c9. No old prerequisite receipt is reused.Actual six-owner archives installed with production dependencies and scripts disabled on held exact candidates, installation/asset plan exit0. Selected SDK helper/scene bytes match native source; original installed strict plan matches source SHA256
ec28114ab8cd3b53bea776cae4692e1dc1938a928ced7176a2149c40c8833031,43mapped/161uncovered/204selected/260deferred, only uncovered diagnostics. Temporary installed dependencies removed in finally. This is installed asset custody and plan inspection, not a managed invocation. Ordinary staging merge/read-back and Agent406 final verification remain pending.Risk and rollback
Golden proof now fails closed on absent exact populated authority and missing independently read references. No general content-schema or product behavior changes. Revert the ordinary merge to remove only this acceptance change, preserving both RED commits and original evidence; no migration, runtime mutation or publication is involved.
Completion summary
Focused checks pass.100/101 and128 remain unchecked;102–109,130,132,134 remain reopened until full CI, source-to-installed custody and exact ordinary delivery pass.131 remains checked.179 remains unchecked for its separate canonical Lease/Reservation producer gap. SDK readiness and managed acceptance remain blocked; the genuine managed Tester/Reviewer/Engineer product defect remains reserved.
Submission checklist