Repository navigation
Share native verification prerequisites with protected publication - #888
Open
adrianwebb wants to merge 4 commits into
Open
adrianwebb wants to merge 4 commits into
adrianwebb wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Protected publication ran Deployment's complete native suite without installing its required disposable host or Reviewer. Actual rc322 publication39402012395 failed18 tests (1327 passed) on missing original installed runtime/broker, native privilege and Reviewer prerequisites. No signed release was published. Verify already owns the complete working sequence; both workflows now invoke that one sequence.
Work authority
Contributor mode:
Plan
Reproduce the missing shared prerequisite contract first; extract the already verified17-step sequence without changing commands/conditions/pins; make Verify and Publish use it; retain complete owner/Reviewer prerequisites before the original coded scenes; run fresh full Actions. Roll forward the still-unpublished rc323 candidate and a new reviewed Platform generation after checks. Preserve the failed rc322 tag/run/composition; never overwrite tags or publish CI fixture packages as real composition.
Changes and commits
Verification
Seven focused contracts/3 files pass;31 other cases excluded by the focused name filter are not full-suite evidence. Strict build and source-shape524-file check pass. Exact before/after structural comparison proves commands, conditions, environments and supply pins unchanged across17 moved steps. A focused packaging contract initially expected inline YAML command text; it now asserts the same effective command and strictly verifies both guards exist before it. Full owner suites/native integration/scenes are pending and required on this candidate before merge/adoption. The first real failed publication remains failed.
Nested SDK context correction: first shared-action run39404251562 stopped before native setup/full suites: the owning SDK action's implicit source-ref input is empty when nested. 3fc8213 first adds the direct-caller/nested-explicit-commit regression; a7c7b4d keeps that original caller-bound installer direct in both workflows while the remaining16 steps stay shared. Nested Reviewer SDK commit remains explicit. Seven focused contracts and strict build pass;17-step effective sequence equivalence passes. No full-suite/scene pass is claimed for that failed run; missing scene artifact is a secondary failure. Fresh full candidate Actions are required.
Risk and rollback
This changes CI composition and publication prerequisites. Local composite resolution uses the checked-out exact tag, so publication must use a new tag containing the action; rc322 is retained as failed history. Revert through protected PR/checks if necessary. No runtime service, development selection, credential, existing retained work, test assertion, scene requirement or deadline is changed.
Completion summary
Native publication has a reproduced structural defect and a bounded shared-path repair. Full exact-candidate Actions and actual signed rc323 publication/read-back remain unproven. APIrc113 released-catalog adoption and the real readiness-counter acting chain remain pending.
Submission checklist