Repository navigation
Keep disabled development targets from restarting healthy services - #884
Merged
Merged
Conversation
Refs #883. Reproduce the real manager resume loop triggered by disabled AI target selections while Admin and package watchers are healthy. Require disabled selections to remain untouched, enabled failed targets to recover, and absent component selections to retain existing behavior. Focused BASE RED: four pass and one intended expected-false/got-true failure in the existing selected stopped-candidate recovery assertion.
Refs #883. Exercise original native Docker readiness and process identity, real persisted DevelopmentSessionStore and strict HostConfiguration reads. Three unchanged reads must preserve exact saved bytes and healthy process identity while disabled candidate selections remain stopped. Re-enabled failed targets and enabled stopped peers must still request recovery. Wire the same native assertion into existing component scenes. Native execution remains pending disposable CI; this commit changes no source.
Refs #883. Apply authoritative host component enablement before deciding to restart an active completed boot worker. Reuse the existing AI target component mapping used by the CLI. Keep disabled selections and all saved generations intact; enabled failed and unspecified selections still need recovery. Strict host configuration read failure prevents mutation. Focused baseline RED: four pass and one intended failure. Repair:29 focused checks pass, no failed or pending assertions; strict tsc passes. Complete native suites and coded scenes precede adoption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Prevent disabled retained development selections from repeatedly restarting healthy source services. An active completed boot worker now reads authoritative host component enablement before deciding whether recovery is needed.
Work authority
Contributor mode (select one):
Plan
Reproduce the supervisor/CLI mismatch before repair. Retain disabled candidate selections while excluding them from automatic recovery; preserve enabled failure recovery. Verify original native process identity and persisted authority, complete native owner suites and coded scenes before checked adoption and repeated live browser validation.
Changes and commits
Verification
Original journal shows the manager stopping/restarting the resume service roughly every minute; its cgroup kills package watchers, UI/Core rebuild and Admin restarts underneath the authenticated browser. Public host configuration explicitly disables ai-inference, ai-training and ai-lab; the existing CLI skips those components while the old supervisor counts them as needing recovery.
Focused BASE RED:4passed/1intended expected-false/got-true failure. An earlier preparation script indentation guard failed before changing tests; the resulting unchanged baseline pass is retained and is not credited as RED. Final focused owning checks:29passed, zero failed/pending. Strict TypeScript and source-shape checks pass.
Native Verify https://github.com/treeseed-ai/deployment/actions/runs/39183851536 passed on tested merge df91cab. Independently audited fresh complete prerequisites:1343Deployment and200Reviewer checks, zero failed/skipped/todo;265coded steps,265assertion receipts and57source-file digests match the exact candidate. Selected archive assets match source; archive SHA256 a86b714175eed78d315f360118fb32b90a28ac8e43ce39500e99dfbf49f49de5; report SHA256 acf2943bd7560f8000fd681f1c8e6f4ef11ada3c4f1678ff8fecd086b9a222d5. The compiled boot module matches the private source build at SHA256 b2a2a0871aabf07869c615b36c0f8a482397d69172e076d50fb2b31cd06a1404.
Backup39183851370, fault qualification39183851298, secret custody and uninstall checks all passed. Artifact ZIP digests and tested merge parents/tree were verified. The operator audit initially used a multi-ref FETCH_HEAD incorrectly and safely rejected it; split protected-head and merge-ref fetches retained the same assertions and passed without changing the candidate.
Checked staging adoption and actual systemd/browser-cycle proof remain pending. Component proof is not a formal managed acceptance pass.
Risk and rollback
Disabled selections remain stopped and retain their modes/generations. Explicit enabled failures and missing component entries still request recovery. Strict configuration read failures prevent restart. Existing holds, stopped-session rules, unprivileged owner custody and fixed installed worker remain unchanged. No timer disabling, broader stop, session expiry, certificate bypass, allowance increase or unrelated cleanup. Revert through ordinary checked delivery if needed; do not edit installed supervisor files manually.
Completion summary
Ordinarily merged to staging0f09f0672e6658d58d7e39647e63b943c28c5cfe, exact tested tree retained. Supported host activation dev-1792373670254-e43e2170 verified all266compiled modules against the archive and all three selected daemon entrypoints. Three subsequent real development reconciliation cycles retained the same resume InvocationID and healthy target generations, guest93e0584b, host configuration and modes. Authenticated Chrome assignment→exact Engineer artifact works again. Remaining metrics/agent-detail failures are separate under SDK428; no formal acceptance pass.
Submission checklist
Refs #883.