Repository navigation
Ship native CLI observation assets through the public binary - #294
Merged
Merged
Conversation
adrianwebb
marked this pull request as ready for review
October 10, 2026 00:11
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
CLI archives retain the selected native workday event and diagnostic acceptance assets. Both original cases execute the package's declared compiled public binary, preserve denied reads and unchanged retries, and no longer invoke checkout source or substitute an unbound command.
Work authority
63c7928b2ab2456e495a0e55572b9a47d379315c5a73cd434a42f237543d30c8b8c7bd5e912ab173Contributor mode (select one):
Plan
Ship the minimum existing native observation closure; preserve independent CLI builds, exact public commands, original native assertions and 30-second deadlines. Run complete owner verification and fresh full prerequisites before component scenes, then ordinary staging merge/read-back after all required checks pass. Installed six-owner acceptance and managed SDK semantics remain separate unresolved gates.
Changes and commits
2f0d5a2: focused regressions reproduce archive omissions, installed missing assets, and checkout source execution.5a73cd434a42f237543d30c8b8c7bd5e912ab173: ship existing metadata/guarantees and minimum assets; move the two native cases intact into acceptance assets, import existing compiled runtime contracts, resolve the sole public binary, and update full-suite discovery/registry paths together.Verification
Focused source command:
node --import tsx --import ./tests/support/os-custody.ts --test tests/contract/package/installed-assets.test.ts tests/acceptance/workday-events.test.ts tests/unit/command-boundary/observation/workday-events.test.ts tests/unit/native-suite-reporting.test.ts tests/integration/native-suite-reporting.test.ts tests/contract/package/thin-package.test.ts: 22/22 passed, zero failed/skipped/todo. Strict TypeScript checks for the three new/converted assets and original file architecture/length checks passed, under Node 24.12.0.Local
npm run verify:directfailed at the original strict SBOM gate before tests/scenes because the retained local dependency tree lacks development dependencies; exact log and failure classification are retained in the Issues. No gate weakened. CompleteTREESEED_DEVELOPMENT_WORKSPACE_ROOT=/tmp/sdk369-platform-authority-de2LzF npm teston this exact candidate passed 369/369 under Node 24.12.0, zero failed/skipped/todo, in 120.1 seconds;/tmp/cli274-installed-assets-full-suite-20261010.log. Clean Actions 38007844944 passednpm run verify:directwith 369/369, then freshly ran all 369 before 168 component scene steps on tested merge8d0919a04c66e911e27a6521519f6c4381fda7c5(tree837b887bc913a554513f43e48df0eb437815b138). All applicable checks passed. Prerequisite source digest723a1ba4a6c99bc3c116e9ed18aa5fd01b94f8cc82d4eb2c113364fb00335c08; scene report SHA25660ff6ae6765c91999f808d73eaa1731880859e722f7dc8ca5173e45321f05865. Scene artifact 11652440908 ZIP SHA256686ce582aa857b70aabb920c140077cb3e9f658018210c009c1e0b30b42fe3b9; package artifact 11651976465 ZIP SHA2561f977558be3b4d7bf0a8d8f8eb0a71abea88daca1541b1143720edb406dd9dbf. Existing component reporting is not a strict managed SDK receipt.Risk and rollback
No API, schema, runtime command, license, deployment or infrastructure change. Native HTTP responses and OS fixture credentials are controlled test inputs, not managed model/API authorization evidence. Actual joined production-owner installed execution remains unproven. Roll back by an ordinary revert of the repair commit through a checked staging PR; preserve the regression commit and failed observations.
Completion summary
Focused archive/public-binary proof passes. The complete local suite passed 369/369. Clean Actions run https://github.com/treeseed-ai/cli/actions/runs/38007844944 passed full verification and fresh complete prerequisites before all 168 component steps. Ordinary staging merge/read-back is next. No managed acceptance campaign, runtime selection, tag or release was created.
Submission checklist
Delivered by ordinary staging merge
22b6a27136a3583f4128cfd763917371e5572985; exact tree837b887bc913a554513f43e48df0eb437815b138matches the tested merge. Source ancestry, clean local fast-forward and exact temporary remote branch deletion independently verified; main unchanged. Component scope only; joined installed and managed SDK proof remain pending.