Repository navigation
Restore published dependencies and settled native report recovery - #589
Merged
Merged
Conversation
47 of 72 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Repair two observed shared-backend blockers in the same portfolio workflow: discover dependencies from the exact published library commit, and acknowledge already-settled native TreeDX report closeouts without requiring a sandbox that was never acquired.
Work authority
Contributor mode (select one):
Plan
This follows merged #588. Protected staging requires an up-to-date branch; merge a1c24f4 incorporates staging855 with a byte-identical tree to locally proven9e38. Required Actions must pass on the updated head before merge. Reproduce the moving-ref discrepancy, pin through existing authority, run focused checks/build, adopt locally and read the real graph, then complete Actions and release.
Changes and commits
Commit9e38e24a3ff48c2605385c3fbcc4bf94fb48fd57 resolves the bound ref with listRepositoryPaths, validates the exact commit, and uses the existing exact-ref grant before querying the graph. Returned graph commit, endpoints, note bytes, digest and all existing checks remain enforced. No schema, additional executor or compatibility path.
The regression returns no graph nodes for the moving ref and the actual relation for its exact commit. Existing signed HTTP fault cases also cover the path-list boundary.
Verification
Focused command: node node_modules/vitest/vitest.mjs run --config vitest.control-plane.config.ts tests/unit/control-plane/capacity/execution/graph/architecture/relations tests/unit/control-plane/capacity/execution/graph/relations/exact-dependency-links.test.ts. Build: npm run build:dist. Controlled HTTP fixture checks are not full native acceptance. Required Actions remain pending; no broad local acceptance campaign claimed.
Risk and rollback
Path-list or exact-ref authorization failures remain fail-closed. No migration. Revert9e38e24a3ff48c2605385c3fbcc4bf94fb48fd57 and rebuild/reselect696bb97fd81eb7a408bc6bbcd8344e7fb1f200a6 to restore the first slice; preserve original failed observations and published note.
Completion summary
The local dependency-discovery repair is proven with the actual published portfolio note. Actions, upstream merge, release and the complete cross-project implementation/review/simulated-release outcome remain pending.
AGPL committer authorization
The existing base-owned authorization check applies; no licensing change.
Submission checklist
Additional real recovery blocker in this candidate
Agent#506 was adopted through the supported provider handoff and freed two native Reporter slots as unresolved while retaining original outputs/period holds. The other two (JGg/HX) reached API acknowledgement and failed its identical sandbox/native.elapsedSeconds assumptions. Public capacity ledger/usage inspection confirms original provider_usage_report settlements already committed once: JG11active/11elapsed, HX10/10, nativeUsage{}; they are not automatic zero settlements or unmeasured charges. Operator unresolved recovery correctly refuses those measured consumed reservations. Do not weaken or change that accounting rule.
Commit0b8e3d2066e3f5010ff6a79a8c1ea4a08b855f74 extends the existing failure acknowledgement for native TreeDX content with no sandbox/environment/guest artifacts. It reuses validateAssignmentResultCompletion for exact original workspace/reference/time authority, preserves all VM receipt rules, and requires an already-consumed reservation before native acknowledgement. The existing full original-scope, ledger/usage, exact-result replay, state-version and event checks still run. Native elapsed is not invented; the canonical integer elapsed must match the already-settled authoritative usage. The expired attempt remains unsuccessful and assignmentResult remainsnull. No extra settlement, refund, new schema or handler-specific policy is added.
Real-shape regression RED at the original sandbox guard (after correcting one test-fixture SQL quoting error).34 cases across terminal-races and3 relation files now pass, including actual owning embedded PostgreSQL service transactions and negative native output/reference/counter cases; strict package build and diff check pass. Controlled clock/content references are test inputs, not real TreeDX/server/physical proof. Live native acknowledgement and independent report read-back remain pending. No full local acceptance campaign claimed.
This small owning API correction is batched into the current runtime candidate rather than creating another competing long verification candidate. Work authority extends to treeseed-ai/agent#496 and the user's explicit retained-claim instruction. The prior9e38/a1c24 observations and required runs remain historical evidence; new required Actions must pass on exact0b8e3d20 before merge. Candidate adoption will wait for active assignment leases to close.
Live adoption at exact0b8e3d20 succeeded through trsd. JG/HX native Reporter closeout acknowledgments released their retained leases while preserving original expired disposition, null canonical assignmentResult, and exactly one original11/10second ledger charge each. Original report files read back at retained commits/hashes. Together with Agent/Deployment fixes, all four October21 claims release concurrency; h5t/5y remain unresolved accounting holds. UI admission now exposes a distinct graph/result revision mismatch tracked in API#590, not a regression in native accounting. Required Verify39663702132 remains pending; no release/formal acceptance claim.