Skip to content

Preserve fixed discussion turns after short chat history - #587

Closed
adrianwebb wants to merge 4 commits into
codex/group-discussion553from
codex/discussion-turn553
Closed

adrianwebb wants to merge 4 commits into
codex/group-discussion553from
codex/discussion-turn553

Conversation

@adrianwebb

@adrianwebb adrianwebb commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Outcome

Fixed discussion turns no longer shrink based on short earlier replies. The real Admin/coordinator planning send declared180 seconds, but received32 after20 historical chat measurements (multiplier0.176326875); both failed. New admissions use the existing declared model-turn budget, still bounded by real supply, provider ceilings and original authority deadlines.

Work authority

Contributor mode (select one):

  • Human-authored
  • Agent-assisted under human authority
  • Agent-authored under human authority

Plan

Bounded follow-up to #586: reproduce actual20-reply history; exclude fixed conversation turns from task-estimate calibration; retain all supply and deadline clamps. Exercise a fresh meaningful Admin/coordinator proposal discussion after supported development adoption. Retarget to staging only after #586 merges; never merge into its dependency branch.

Changes and commits

  • e755ed92: regression reproduces the actual history-driven reduction before repair.
  • 788539ae: conversation turns use the same uncalibrated fixed-model-turn semantics as planning turns. Task/review estimate calibration remains intact.
  • No increased configured allowance, extended issued deadline, changed failure history, new configuration or dispatch path.

Verification

  • Regression failed on the original code with all20 short-reply measurement IDs applied.
  • node node_modules/vitest/vitest.mjs run --config vitest.control-plane.config.ts tests/unit/control-plane/capacity/execution/assignment-attempt-builder.test.ts tests/unit/control-plane/capacity/execution/admission/assignment-active-window.test.ts:31 passed.
  • Regression covers both phases,3-second remaining supply, zero-supply denial, existing30-second authority-window clamp and input immutability; existing review-history calibration retained.
  • npm run build:dist and npm run check:file-lengths:passed with Node24.
  • Required Actions and fresh real discussion remain pending. This is not formal group-workflow acceptance.
  • I ran the narrowest relevant package verification and documented any checks that could not be run.

Risk and rollback

Fresh conversations may reserve the full declared model-turn budget instead of an allowance learned from acknowledgements. Real supply/provider/deadline clamps and exactly-once accounting are unchanged. Revert 788539ae through a new PR and supported runtime reconciliation if required; preserve original failed attempts and never mutate running authority.

Completion summary

The admission defect is reproduced and repaired locally. Required CI, staged merge and fresh meaningful discussion remain open. Exact UI product retrieval/release is a separate existing delivery gap.

AGPL committer authorization

Existing base-owned provider-authenticated allowlist applies.

Submission checklist

  • The change is bounded to the stated work item and target repository.
  • Exact base and head refs are recorded and the branch is ready for review.
  • Verification and compatibility evidence are recorded above.
  • No plaintext secrets, credentials, machine state, or unrelated residue are included.
  • Plan, status, commits, and completion summary form a complete durable record.
  • Rollback or recovery steps are documented and executable.

Exact candidate follow-up

Retained failed run 39469798828: package verification passed; the coded scene stopped after 73 passes on a stale exact native-test name. Inherited #585 binding repairs plus 2fd0f4f8 bind the fixed discussion regression by its current name. Focused discussion regression passed; fresh required Actions are running on the exact head above. No coverage or assertion was removed. Fresh meaningful coordinator/Deployment discussion send-86150ea550532ff262213bc33b460c7f completed for both agents; this is coached evidence, not formal acceptance.

Protected delivery: this exact slice head2fd0f4f88c571ecdbaec82d883a312b5aa7c97a2 is retained as an ancestor of cumulative API PR585's protected staging merged0d726be81701eb1b157b348697834b7358e3068. Required Verify39569564428 passed on cumulative head38892d88397e3bd577e30f3097dfa1afc40b1d5b; earlier failed/cancelled runs remain historical failures, not passing receipts. The stack was delivered together to avoid duplicate full campaigns. Fresh protected fetch and Git ancestry checks passed.

Closed as delivered through cumulative PR #585 (not individually merged): exact slice commit2fd0f4f8 is already in protected stagingd0d726be; no duplicate merge or passing claim for the old cancelled checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant