Repository navigation
Preserve fixed discussion turns after short chat history - #587
Closed
adrianwebb wants to merge 4 commits into
Closed
adrianwebb wants to merge 4 commits into
adrianwebb wants to merge 4 commits into
Conversation
7 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixed discussion turns no longer shrink based on short earlier replies. The real Admin/coordinator planning send declared180 seconds, but received32 after20 historical chat measurements (multiplier0.176326875); both failed. New admissions use the existing declared model-turn budget, still bounded by real supply, provider ceilings and original authority deadlines.
Work authority
fbd7342a-dbb1-4ee3-84dd-bf7ffa1c3a1c; UI Decision7fcf2c92-0c7d-44a9-b1c6-cba49a79ed45.send-d71e99491e32661c5e7200b100ad24a2; Adminassignment_dQtVtwSAczwm9rlypexSLZ9go-_vQLDefailed assignment_timeout; coordinatorassignment_0FQV-bRgacTbbUJ05b1B3cx_wSfciIVyfailed expired_lease_side_effect_evidence_present.provider_-rcKRK8gG2NGnOU3yGu_CV3Wz7ACppTP.codex/group-discussion553at0daf6e36c1f17f651638f0e4efa43e67b09fc3ab; protected staging freshly fetched0df73b38026c80a321abd428a7e78f33dddc72bb.codex/discussion-turn553at2fd0f4f88c571ecdbaec82d883a312b5aa7c97a2.Contributor mode (select one):
Plan
Bounded follow-up to #586: reproduce actual20-reply history; exclude fixed conversation turns from task-estimate calibration; retain all supply and deadline clamps. Exercise a fresh meaningful Admin/coordinator proposal discussion after supported development adoption. Retarget to staging only after #586 merges; never merge into its dependency branch.
Changes and commits
e755ed92: regression reproduces the actual history-driven reduction before repair.788539ae: conversation turns use the same uncalibrated fixed-model-turn semantics as planning turns. Task/review estimate calibration remains intact.Verification
node node_modules/vitest/vitest.mjs run --config vitest.control-plane.config.ts tests/unit/control-plane/capacity/execution/assignment-attempt-builder.test.ts tests/unit/control-plane/capacity/execution/admission/assignment-active-window.test.ts:31 passed.npm run build:distandnpm run check:file-lengths:passed with Node24.Risk and rollback
Fresh conversations may reserve the full declared model-turn budget instead of an allowance learned from acknowledgements. Real supply/provider/deadline clamps and exactly-once accounting are unchanged. Revert
788539aethrough a new PR and supported runtime reconciliation if required; preserve original failed attempts and never mutate running authority.Completion summary
The admission defect is reproduced and repaired locally. Required CI, staged merge and fresh meaningful discussion remain open. Exact UI product retrieval/release is a separate existing delivery gap.
AGPL committer authorization
Existing base-owned provider-authenticated allowlist applies.
Submission checklist
Exact candidate follow-up
Retained failed run 39469798828: package verification passed; the coded scene stopped after 73 passes on a stale exact native-test name. Inherited #585 binding repairs plus
2fd0f4f8bind the fixed discussion regression by its current name. Focused discussion regression passed; fresh required Actions are running on the exact head above. No coverage or assertion was removed. Fresh meaningful coordinator/Deployment discussionsend-86150ea550532ff262213bc33b460c7fcompleted for both agents; this is coached evidence, not formal acceptance.Protected delivery: this exact slice head2fd0f4f88c571ecdbaec82d883a312b5aa7c97a2 is retained as an ancestor of cumulative API PR585's protected staging merged0d726be81701eb1b157b348697834b7358e3068. Required Verify39569564428 passed on cumulative head38892d88397e3bd577e30f3097dfa1afc40b1d5b; earlier failed/cancelled runs remain historical failures, not passing receipts. The stack was delivered together to avoid duplicate full campaigns. Fresh protected fetch and Git ancestry checks passed.
Closed as delivered through cumulative PR #585 (not individually merged): exact slice commit2fd0f4f8 is already in protected stagingd0d726be; no duplicate merge or passing claim for the old cancelled checks.