Repository navigation
Deny omitted completed sandbox histories in clock acceptance - #421
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Reject a completed sandbox-backed assignment missing from the original public model-start history, even when other model executions are complete. Preserve failed preparation without claiming a model invocation.
Work authority
Work item / Issue: Complete capacity-provider and Agent acceptance — continuation of #339 #368 and Continue strict acceptance bindings: current checklist and native reconciliation delivery sdk#401; original partial criterion 11.
Proposal / decision: Explicit user-authorized strict capacity-provider and agent-execution acceptance implementation plan.
Assignment / checkpoint: Existing Agent clock observation consumer and native public SDK boundary, paired with Prove complete native model custody for protected clock acceptance api#538.
Actor: Codex through provider-authenticated adrianwebb.
Human authority: adrianwebb, explicit implementation authorization.
Agent / capacity provider: Codex in authorized local workspace.
Exact base ref: staging
24a00f8470d34ca3ad9a774e6ff59b59bccbb223.Exact head ref: codex/agent-clock-custody-401
5be4daf951cc111cab32f7aac94d6f10d7ed02f6.Exact proposed merge:
af037d7dd0a9951c0168f19c3da31812d55ddf7c, tree30fc9dbeaea2a4507543d9eaeb315d52dbba76f3.Fresh native verification: https://github.com/treeseed-ai/agent/actions/runs/38193663039 (SUCCESS).
Contributor mode (select one):
Plan
Commit the original focused RED before repairing the existing modelExecutionInventory assertion. Extend the existing independent native HTTP/public SDK test with omitted completed-sandbox custody and exact denial/retry history. Reuse the same registered unit/native component and normal SDK clock verifiers. No role name, dispatch path or runtime model flag is added.
Changes and commits
Committed focused RED cab38b0; original-helper repair and existing native public SDK test5be4daf951cc111cab32f7aac94d6f10d7ed02f6. Three existing files changed.
Verification
cab38b088f05e7eef0243f6a1b964952ed5e482b: original timing file19tests/18passed/1failed/0skipped. Existing consumer accepted an omitted completed sandbox assignment. IMPLEMENTATION_DEFECT classification recorded in SDK Bind six authored SDK proposal rows to selected public product proof #401 before repair.5be4daf951cc111cab32f7aac94d6f10d7ed02f6: timing and native public SDK/HTTP files26/26, zero skips. Valid completed/failed/returned model histories, failed preparation, malformed markers, omitted custody, original denial and exact retry remain distinct.npm run typecheck,npm run check:file-lengthsandnpm run build:distpassed.Completion summary
Three existing acceptance/helper/test files only. Public API, SDK product source, governed role configuration, runtime dispatch and normal SDK scene selection/order are unchanged. The original177checklist remains33completed/144open. Original partial11 remains unproven until both owner candidates pass all delivery gates.
Risk and rollback
Retain focused RED and failed observations. Repair any verified failure on ordinary commit lineage before replacing the held candidate. Recover by an ordinary reviewed revert; retain existing guarantees and historical evidence. No release, tag, deployment, runtime selection, worktree or broad cleanup is introduced.
Fresh native candidate evidence
Verify38193663039 SUCCESS on tested merge af037d7/tree30fc9dbeaea2a4507543d9eaeb315d52dbba76f3. Independent strict report audit: fresh complete Agent991/991 and executing Reviewer200/200 before739/739 component steps; zero failed/skipped/todo/blocked. All739 original assertion receipts and118 source-file digests reconcile exactly. Twelve checked archive assets, including the changed clock helper, match native Git and source receipts. Actual archiveSHA2569c99405def3ae8a9ab89d5f4d5d1140e43431f9c06673b54cbc1139631a31999; reportSHAd6c2d0595854473c7d2b77543ba52385894f7725fb663d165e5c2f709fdcd028. Official ZIP digests independently verified: scenes fe167adf58fb1981089e208873a0e416bc579fbd102b3b0fa9580981e86f0636; package7e7e060d5038726e0789f02ece30b18e2b124ec0d41b4a0d9c614dd286022c2f. Original artifacts retained. Actual six-owner installed production Reviewer-loader proof, paired API538 and ordinary staging read-back remain pending before binding11 completion. No managed acceptance pass is claimed.
Installed candidate execution
Actual six-owner archives installed with --omit=dev --ignore-scripts, reusing the existing sole held SDK archive override. The changed Agent helper executes from its actual CI archive9c99405def3ae8a9ab89d5f4d5d1140e43431f9c06673b54cbc1139631a31999 through the installed Reviewer production tsx loader. Both native/public clock inventory helpers pass their controlled positive and5denials each with unchanged input/asset bytes. No source or development-dependency runtime fallback. Additional strict compiler diagnostic0; npm ls --all --omit=dev and installed CLI help pass. Source/installed selected plan agrees byte-for-byte SHA492a3120b3f52462deb43badb27f8cbd8ad59d3615d184add4c267854b1fab69:61mapped/143uncovered/204selected/260deferred/464full. API currently uses actual locally produced held86ad181b archive23f2c679175a10c4a3d1f492f65f15fdee7402fc55e5493939808e40cac5a512; its pending native CI archive must independently reconcile before paired binding11 completion. This is installed asset closure proof, not a managed model invocation or SDK passing receipt.
Submission checklist