Skip to content

Support for ARM64 (Fixes #22) - #25

Open
sahilph wants to merge 31 commits into
masterfrom
add-arm64-support
Open

Support for ARM64 (Fixes #22)#25
sahilph wants to merge 31 commits into
masterfrom
add-arm64-support

Conversation

@sahilph

@sahilph sahilph commented Jun 11, 2018

Copy link
Copy Markdown
Member

Overview

Support for ARM64

Testing recommendations

Multi-arch manifest pushed. Just use treehouses/couchdb on a arm64 device and it will run.
To access 64Bit specifically use:
treehouses/rpi-couchdb:arm64-2.1.1-0.0.1-add-arm64-support-5a2b63ca

GitHub issue number

(Fixes #22)

Related Pull Requests

N/A

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@dogi
dogi requested review from akshayuncc, dogi and empeje June 12, 2018 16:26

@empeje empeje left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough, only small comment.

Comment thread .travis/travis_utils.sh Outdated
mv 2.1.1/Dockerfile-arm64 2.1.1/Dockerfile
if [ "$BRANCH" = "master" ]
then
sed -i -e "s|\(treehouses\/rpi-couchdb:2\.1\.1\)|$V211_DOCKER_NAME_LATEST|" 2.1.1/Dockerfile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sed is faster, but for OLE you create YAML on the fly, any specific reason not doing that what in this repo?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason as such. This is how we used to do it before I found the method to create it on the fly. 馃槈

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃啑

@empeje

empeje commented Jul 23, 2018

Copy link
Copy Markdown
Member

Is this finally working @dogi and @sahilph?

I can merge this after you fix the conflicts.

@sahilph

sahilph commented Jul 24, 2018

Copy link
Copy Markdown
Member Author

@empeje
Oh. This one wasn't merged yet 馃槄 ? I'll fix the conflicts and then you can merge it

@sahilph

sahilph commented Jul 24, 2018

Copy link
Copy Markdown
Member Author

@empeje I have fix the conflicts and also removed the versions which can't be compiled. Since the version is updated to 2.1.2 and 1.7.2 we should first test them on arm64 after the build finishes.

@empeje empeje self-assigned this Sep 13, 2018
@empeje

empeje commented Sep 13, 2018

Copy link
Copy Markdown
Member

Step to test:

  • Install Ubuntu on Raspberry Pi 3
  • Test it on Raspberry Pi 3

@empeje

empeje commented Nov 15, 2020

Copy link
Copy Markdown
Member

Hi @dogi, hope you're doing good. Since I'm no longer working on the treehouses project, could you please unassign me from this MR?

@empeje empeje removed their assignment Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aarch64 support

2 participants