Centralize duplicated test-suite helpers into shared test/lib package - #251
Conversation
Co-authored-by: maansaake <15028979+maansaake@users.noreply.github.com>
test/lib package
maansaake
left a comment
There was a problem hiding this comment.
All helpers_ files you've created need to be moved to lib, I don't want any helpers_ files UNLESS they are needed specifically for several test suite test cases in that suite ONLY. Even then there should be special reasons to do so. In addition, you've actually reimplemented checks like CheckErr in individual helpers, make sure you use the lib package for helper-style functions now. Also, ensure you clean up lib_* files as well, there were some additional ones in the integration suite at least, maybe more.
Co-authored-by: maansaake <15028979+maansaake@users.noreply.github.com>
Addressed in 314a66b. I removed all |
Co-authored-by: maansaake <15028979+maansaake@users.noreply.github.com>
Co-authored-by: maansaake <15028979+maansaake@users.noreply.github.com>
…ias to lib Co-authored-by: maansaake <15028979+maansaake@users.noreply.github.com>
…directly Co-authored-by: maansaake <15028979+maansaake@users.noreply.github.com>
This PR consolidates duplicated library-style test helpers that were spread across integration, security, and connector suites into a single shared package. It also removes all suite-level
lib.gofiles and replaces them with content-scoped helper files.What changed
test/suites/libassertions.go(error/status/header assertions)cookies.go(session/refresh cookie extraction, request-editor helpers)environment.go(host/port/env lookups)Suite refactor
lib.gofiles with content-based helper files:test/suites/integration/helpers_*.gotest/suites/security/helpers_*.gotest/suites/connector/helpers_*.gotest/suites/lib.Repo cleanup
test/suites/integration/lib.gotest/suites/security/lib.gotest/suites/connector/lib.golib.gofiles remain in the test suites.