Skip to content

hotfix: parche deepmerge-ts y habilita cuentas admins de la USCO - #190

Merged
trbureiyan merged 5 commits into
mainfrom
hotfix/deepmerge-ts-usco-auth
Aug 17, 2026
Merged

hotfix: parche deepmerge-ts y habilita cuentas admins de la USCO#190
trbureiyan merged 5 commits into
mainfrom
hotfix/deepmerge-ts-usco-auth

Conversation

@trbureiyan

@trbureiyan trbureiyan commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Resumen

  • Aplica el parche a deepmerge-ts para actualizarlo a la versión 8.0.0 mediante el override de pnpm.
  • Permite el registro e inicio de sesión con cualquier dirección válida @usco.edu.co.
  • Mantiene el requisito estricto del dominio institucional; las variantes de subdominio siguen bloqueadas.
  • Agrega cobertura de pruebas de regresión para formatos de correo de profesores y administradores.

Verificación

  • pnpm test — 146 pasaron
  • pnpm lint — 0 errores
  • npx tsc --noEmit — sin errores
  • pnpm build — pendiente (requiere variables de entorno)
Análisis automático de CodeRabbit

Cambios principales

  • Se actualizó deepmerge-ts a la versión 8.0.0 mediante un override en pnpm-workspace.yaml.
  • Se habilitó el registro y el inicio de sesión para cualquier dirección válida con dominio exacto @usco.edu.co.
  • Se mantuvieron bloqueadas las direcciones de subdominios.
  • Se añadieron pruebas de regresión para correos de profesores y administradores.
  • Se actualizó la documentación de riesgos de autenticación en AGENTS.md.

Verificación

  • pnpm test: 146 pruebas exitosas.
  • pnpm lint: 0 errores.
  • npx tsc --noEmit: sin errores.
  • pnpm build: pendiente por variables de entorno requeridas.

trbureiyan and others added 4 commits August 17, 2026 16:01
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NdbkqktLvD9XHtLHf3nThV
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NdbkqktLvD9XHtLHf3nThV
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NdbkqktLvD9XHtLHf3nThV
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NdbkqktLvD9XHtLHf3nThV
@trbureiyan trbureiyan self-assigned this Aug 17, 2026
@trbureiyan trbureiyan added security About vulnerabilities and security updates or fixes fix Corrección de bugs o comportamiento incorrecto labels Aug 17, 2026
@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
devurity-web Ready Ready Preview Aug 17, 2026 9:27pm

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@trbureiyan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b7b09f05-2cee-40ac-8bb5-06952b75f953

📥 Commits

Reviewing files that changed from the base of the PR and between e64aad9 and ead3d1e.

📒 Files selected for processing (2)
  • lib/regex.ts
  • tests/regex.node-test.ts
📝 Walkthrough

Walkthrough

La validación de correo institucional acepta cualquier parte local válida de @usco.edu.co. Login y registro aplican esta validación con el correo normalizado. Las pruebas cubren formatos válidos e inválidos. También se añade una sobrescritura para deepmerge-ts.

Changes

Validación de correo institucional

Layer / File(s) Summary
Contrato y pruebas de emailUniversity
lib/regex.ts, tests/regex.node-test.ts
emailUniversity acepta partes locales institucionales generales. Las pruebas cubren códigos estudiantiles, direcciones de profesores, alias administrativos, espacios, dominios incorrectos y mayúsculas.
Integración en autenticación
app/auth/login/page.tsx, app/auth/register/page.tsx, AGENTS.md
Login y registro usan emailUniversity con el correo recortado y convertido a minúsculas. La documentación del flujo JWT refleja la nueva validación.

Configuración de resolución

Layer / File(s) Summary
Sobrescritura de deepmerge-ts
pnpm-workspace.yaml
Se añade deepmerge-ts versión 8.0.0 bajo overrides, con un comentario explicativo.

Estimated code review effort: 2 (Simple) | ~10 minutos

Merge Risk: 🟡 Moderate · up to e64aa

The authentication change still permits malformed institutional email addresses with leading, trailing, or consecutive dots. The validation rule and regression tests should be corrected before merging to avoid accepting addresses outside the intended format.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed El título identifica los dos cambios principales: el parche de deepmerge-ts y la habilitación de cuentas institucionales USCO.
Description check ✅ Passed La descripción resume el objetivo, los cambios y los resultados de las verificaciones; también indica que la compilación queda pendiente por variables de entorno.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@trbureiyan
trbureiyan merged commit efdbc5a into main Aug 17, 2026
8 of 9 checks passed
@trbureiyan
trbureiyan deleted the hotfix/deepmerge-ts-usco-auth branch August 18, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Corrección de bugs o comportamiento incorrecto security About vulnerabilities and security updates or fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant