Fix filtering of QualityCurrentID column - #121
Open
see24 wants to merge 9 commits into
Open
Conversation
It has some more lines at the top that should be skipped
Author
|
New commits added to deal with 2022 release data and to add new sb_ids to sb_items table. I added a new function to update the sb_items table based on the parent ids for ScienceBase. fixes #122 |
some names have changed since the list being used was made would be better to have list corresponding to year
Owner
|
Yikes, my apologies. I obviously haven't been on Github in... a while. I will take a look at this. |
Removed the species_list package dataset. Fix Windows encoding/decoding issues emerging from the BBS species metadata. Update citation. Update messaging/cat prints. import_bbs_data: removed files
trashbirdecology
requested changes
Jan 16, 2026
trashbirdecology
left a comment
trashbirdecology
left a comment
Owner
There was a problem hiding this comment.
Reviewed, accepted/rejected and tested. Also ran through entire package again since last update was... a while ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #120
QualityCurrentID was not being filtered due to the column and function argument having the same name. Fixed by changing the name before filtering and adding a test.