Skip to content

Break out individual witness handlers - #588

Merged
AlCutter merged 1 commit into
transparency-dev:mainfrom
AlCutter:break_out_handlers
Aug 11, 2026
Merged

Break out individual witness handlers#588
AlCutter merged 1 commit into
transparency-dev:mainfrom
AlCutter:break_out_handlers

Conversation

@AlCutter

Copy link
Copy Markdown
Contributor

This PR enables folks using the witness package for their own witness implementations to have more control over registering individual HTTP handlers.

@AlCutter
AlCutter requested a review from phbnf August 11, 2026 15:09
@codecov-commenter

codecov-commenter commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.00000% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.30%. Comparing base (f643e59) to head (fc286ae).

Files with missing lines Patch % Lines
witness/http.go 8.00% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   27.40%   27.30%   -0.10%     
==========================================
  Files          28       28              
  Lines        2189     2197       +8     
==========================================
  Hits          600      600              
- Misses       1461     1469       +8     
  Partials      128      128              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlCutter
AlCutter force-pushed the break_out_handlers branch from b49b0c6 to 52f02ae Compare August 11, 2026 15:12
Comment thread witness/http.go Outdated
type HTTPHandler struct {
witness witness
addCheckpointHandler http.HandlerFunc
subSubtreeHandler http.HandlerFunc

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signSubtreeHandler?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 ta, done

@AlCutter
AlCutter force-pushed the break_out_handlers branch from 52f02ae to fc286ae Compare August 11, 2026 16:07
@AlCutter
AlCutter merged commit ce89de7 into transparency-dev:main Aug 11, 2026
14 checks passed
@AlCutter
AlCutter deleted the break_out_handlers branch August 11, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants