[sqlite] Take DB path rather than opened database - #564
Merged
Conversation
AlCutter
force-pushed
the
sqlite_take_path
branch
3 times, most recently
from
June 17, 2026 14:35
9cf8202 to
ba5c9a7
Compare
AlCutter
marked this pull request as ready for review
June 17, 2026 14:35
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 24.98% 25.30% +0.31%
==========================================
Files 27 27
Lines 2025 2035 +10
==========================================
+ Hits 506 515 +9
Misses 1409 1409
- Partials 110 111 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlCutter
force-pushed
the
sqlite_take_path
branch
from
June 17, 2026 14:37
ba5c9a7 to
e5bbea3
Compare
mhutchinson
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the sqlite persistence c'tor use a path (via opts struct) to an sqlite DB file, rather than taking an opened DB.
The sqlite pragma options are important for the durability and correctness of the witness DB, so we shouldn't rely on the caller having correctly added them when opening a DB.