Set connection URI params that work - #562
Merged
mhutchinson merged 1 commit intoJun 17, 2026
Merged
Conversation
The modernc sqlite implementation didn't use the same parameter names as the old one, and they were ignored silently. This change restores the same behaviour. I explicitly set the default value for synchronous because changing this to NORMAL means that some transactions could be dropped, which the witness can't permit without breaking its claims.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 24.83% 24.83%
=======================================
Files 27 27
Lines 2009 2009
=======================================
Hits 499 499
Misses 1404 1404
Partials 106 106 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlCutter
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modernc sqlite implementation didn't use the same parameter names as the old one, and they were ignored silently. This change restores the same behaviour. I explicitly set the default value for synchronous because changing this to NORMAL means that some transactions could be dropped, which the witness can't permit without breaking its claims.