Skip to content

Set connection URI params that work - #562

Merged
mhutchinson merged 1 commit into
transparency-dev:mainfrom
mhutchinson:sqlite/connectionParams
Jun 17, 2026
Merged

Set connection URI params that work#562
mhutchinson merged 1 commit into
transparency-dev:mainfrom
mhutchinson:sqlite/connectionParams

Conversation

@mhutchinson

Copy link
Copy Markdown
Contributor

The modernc sqlite implementation didn't use the same parameter names as the old one, and they were ignored silently. This change restores the same behaviour. I explicitly set the default value for synchronous because changing this to NORMAL means that some transactions could be dropped, which the witness can't permit without breaking its claims.

The modernc sqlite implementation didn't use the same parameter names as the old one, and they were ignored silently. This change restores the same behaviour. I explicitly set the default value for synchronous because changing this to NORMAL means that some transactions could be dropped, which the witness can't permit without breaking its claims.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 24.83%. Comparing base (4d16f34) to head (729542a).

Files with missing lines Patch % Lines
cmd/omniwitness/monolith.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   24.83%   24.83%           
=======================================
  Files          27       27           
  Lines        2009     2009           
=======================================
  Hits          499      499           
  Misses       1404     1404           
  Partials      106      106           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mhutchinson
mhutchinson merged commit 8feeb61 into transparency-dev:main Jun 17, 2026
13 checks passed
@mhutchinson
mhutchinson deleted the sqlite/connectionParams branch June 17, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants