Avoid re-entrant transactions - #561
Merged
mhutchinson merged 3 commits intoJun 17, 2026
Merged
Conversation
The previous implementation would read the log verifier key in the middle of an Update transaction. This could cause a new DB connection to be needed, which would deadlock if none were available. Considering that the storage layer is in the TCB, skipping verification of this signature is a safe and pragmatic choice. In addition to resolving this minor performance issue, it makes it easier to support log key rotations in the future.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
+ Coverage 24.83% 24.98% +0.14%
==========================================
Files 27 27
Lines 2009 2025 +16
==========================================
+ Hits 499 506 +7
- Misses 1404 1409 +5
- Partials 106 110 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlCutter
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation would read the log verifier key in the middle of an Update transaction. This could cause a new DB connection to be needed, which would deadlock if none were available.
Considering that the storage layer is in the TCB, skipping verification of this signature is a safe and pragmatic choice. In addition to resolving this minor performance issue, it makes it easier to support log key rotations in the future.