Skip to content

Expose persistence package - #554

Merged
AlCutter merged 4 commits into
transparency-dev:mainfrom
AlCutter:expose_persistence
Jun 15, 2026
Merged

Expose persistence package#554
AlCutter merged 4 commits into
transparency-dev:mainfrom
AlCutter:expose_persistence

Conversation

@AlCutter

Copy link
Copy Markdown
Contributor

This PR exposes the persistence implementations so that they can be used if folks want to build or embed their own witnesses.

Also moves the GCP Spanner persistence implementation over to sit alongside the others, and renames the sql implementation to sqlite to better reflect the dependency.

@codecov-commenter

codecov-commenter commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.12%. Comparing base (9ccbfe3) to head (fbb072c).

Files with missing lines Patch % Lines
persistence/inmemory/inmemory.go 62.50% 3 Missing ⚠️
cmd/omniwitness/monolith.go 0.00% 2 Missing ⚠️
cmd/omniwitness_gcp/main.go 0.00% 2 Missing ⚠️
persistence/spanner/persistence.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   24.37%   24.12%   -0.25%     
==========================================
  Files          30       30              
  Lines        2064     2064              
==========================================
- Hits          503      498       -5     
- Misses       1464     1469       +5     
  Partials       97       97              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlCutter
AlCutter force-pushed the expose_persistence branch from 6df7a5c to fbb072c Compare June 15, 2026 12:40
@AlCutter
AlCutter marked this pull request as ready for review June 15, 2026 12:43
@AlCutter
AlCutter merged commit 2e3c008 into transparency-dev:main Jun 15, 2026
13 checks passed
@AlCutter
AlCutter deleted the expose_persistence branch June 15, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants