Fix runfeeders config - #550
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 23.02% 24.37% +1.34%
==========================================
Files 30 30
Lines 2063 2064 +1
==========================================
+ Hits 475 503 +28
+ Misses 1499 1464 -35
- Partials 89 97 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roger2hk
approved these changes
Jun 11, 2026
| if err != nil { | ||
| t.Fatal("failed to unmarshal config", err) | ||
| } | ||
| { |
Contributor
There was a problem hiding this comment.
Seems like the { on L32 and } on L59 are not necessary.
|
|
||
| fCfg, err := newStaticFeederConfig(cfg) | ||
| if err != nil { | ||
| t.Fatal("failed to unmarshal config", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Fatal("failed to unmarshal config", err) | |
| t.Fatalf("Failed to unmarshal config: %v", err) |
| } | ||
| got++ | ||
| if f.Log.URL != wantURL { | ||
| t.Errorf("got URL %q want %q", f.Log.URL, wantURL) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Errorf("got URL %q want %q", f.Log.URL, wantURL) | |
| t.Errorf("got URL %q, want %q", f.Log.URL, wantURL) |
| t.Errorf("got URL %q want %q", f.Log.URL, wantURL) | ||
| } | ||
| if f.Log.Origin != wantOrigin { | ||
| t.Errorf("got Origin %q want %q", f.Log.Origin, wantOrigin) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Errorf("got Origin %q want %q", f.Log.Origin, wantOrigin) | |
| t.Errorf("got Origin %q, want %q", f.Log.Origin, wantOrigin) |
| t.Errorf("got Origin %q want %q", f.Log.Origin, wantOrigin) | ||
| } | ||
| if f.Log.VKey != wantPublicKey { | ||
| t.Errorf("got VKey %q want %q", f.Log.VKey, wantPublicKey) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Errorf("got VKey %q want %q", f.Log.VKey, wantPublicKey) | |
| t.Errorf("got VKey %q, want %q", f.Log.VKey, wantPublicKey) |
| t.Errorf("got VKey %q want %q", f.Log.VKey, wantPublicKey) | ||
| } | ||
| if f.Log.Verifier == nil { | ||
| t.Error("got nil Verifier want non-nil") |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Error("got nil Verifier want non-nil") | |
| t.Error("got nil Verifier, want non-nil") |
roger2hk
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.