Skip to content

Make feedwitness able to serve metrics - #405

Merged
AlCutter merged 1 commit into
transparency-dev:mainfrom
AlCutter:feedwitness_metrics
Sep 4, 2025
Merged

AlCutter merged 1 commit into
transparency-dev:mainfrom
AlCutter:feedwitness_metrics

Conversation

@AlCutter

@AlCutter AlCutter commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Sep 4, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.50%. Comparing base (3c58af4) to head (d41449c).
⚠️ Report is 217 commits behind head on main.

Files with missing lines Patch % Lines
cmd/feedwitness/main.go 0.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3c58af4) and HEAD (d41449c). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3c58af4) HEAD (d41449c)
4 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #405       +/-   ##
===========================================
- Coverage   51.05%   20.50%   -30.55%     
===========================================
  Files          11       27       +16     
  Lines         903     2048     +1145     
===========================================
- Hits          461      420       -41     
- Misses        374     1567     +1193     
+ Partials       68       61        -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlCutter
AlCutter force-pushed the feedwitness_metrics branch from 384fbf1 to 2f5638d Compare September 4, 2025 16:42
@AlCutter
AlCutter force-pushed the feedwitness_metrics branch from 2f5638d to d41449c Compare September 4, 2025 16:52

@roger2hk roger2hk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to gracefully shutdown the HTTP server when the application is terminated?

@AlCutter

AlCutter commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

Good question - I don't think it matters all that much for this, can come back and add it later if it turns out I'm wrong, though.

@AlCutter
AlCutter merged commit 2b9cc67 into transparency-dev:main Sep 4, 2025
6 checks passed
@AlCutter
AlCutter deleted the feedwitness_metrics branch September 4, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants