Make feedwitness able to serve metrics - #405
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
===========================================
- Coverage 51.05% 20.50% -30.55%
===========================================
Files 11 27 +16
Lines 903 2048 +1145
===========================================
- Hits 461 420 -41
- Misses 374 1567 +1193
+ Partials 68 61 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlCutter
force-pushed
the
feedwitness_metrics
branch
from
September 4, 2025 16:42
384fbf1 to
2f5638d
Compare
AlCutter
force-pushed
the
feedwitness_metrics
branch
from
September 4, 2025 16:52
2f5638d to
d41449c
Compare
roger2hk
approved these changes
Sep 4, 2025
roger2hk
left a comment
Contributor
There was a problem hiding this comment.
Do we need to gracefully shutdown the HTTP server when the application is terminated?
Contributor
Author
|
Good question - I don't think it matters all that much for this, can come back and add it later if it turns out I'm wrong, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.