Add OmniGCP - #385
Merged
Merged
Add OmniGCP#385
Conversation
AlCutter
force-pushed
the
omnigcp
branch
2 times, most recently
from
August 20, 2025 13:52
4410c13 to
af3e3be
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
===========================================
- Coverage 51.05% 19.57% -31.48%
===========================================
Files 11 28 +17
Lines 903 1977 +1074
===========================================
- Hits 461 387 -74
- Misses 374 1526 +1152
+ Partials 68 64 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhutchinson
reviewed
Aug 20, 2025
mhutchinson
reviewed
Aug 20, 2025
AlCutter
force-pushed
the
omnigcp
branch
2 times, most recently
from
August 20, 2025 14:20
6fe6333 to
5032c6e
Compare
AlCutter
force-pushed
the
omnigcp
branch
2 times, most recently
from
August 20, 2025 14:46
3312f0a to
f5b53ab
Compare
mhutchinson
approved these changes
Aug 20, 2025
mhutchinson
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a GCP-specific binary for running
omniwitness, along with a Spanner-based persistence implementation, and a Secret Manager based signer.Towards #386