Skip to content

Tighten log-list format specification - #50

Open
FiloSottile wants to merge 1 commit into
mainfrom
filippo/log-list-format
Open

Tighten log-list format specification#50
FiloSottile wants to merge 1 commit into
mainfrom
filippo/log-list-format

Conversation

@FiloSottile

Copy link
Copy Markdown
Collaborator

No description provided.

@FiloSottile
FiloSottile requested review from AlCutter and rgdd August 4, 2026 17:12

@AlCutter AlCutter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, micro-nits inline.

Comment thread log-list-format.md
This document describes a line-terminated log-list format.

Lines are separated by newline (0x0A) characters.
Lines have all leading and trailing space (0x20) and tab (0x09) removed before processing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Lines have all leading and trailing space (0x20) and tab (0x09) removed before processing.
Lines have all leading and trailing spaces (0x20) and tabs (0x09) removed before processing.

Comment thread log-list-format.md
`ORIGIN` the log's origin line, see
<https://C2SP.org/tlog-checkpoint#note-text>. If omitted, the log's origin line
defaults to the vkey key-name. This is recommended for newly deployed logs.
`ORIGIN` the log's origin line, see <https://C2SP.org/tlog-checkpoint#note-text>.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`ORIGIN` the log's origin line, see <https://C2SP.org/tlog-checkpoint#note-text>.
`ORIGIN` is the log's origin line, see <https://C2SP.org/tlog-checkpoint#note-text>.

@rgdd rgdd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants