This repository was archived by the owner on Nov 7, 2025. It is now read-only.
tapas_physio_pca -> no voxel limitation - #192
Open
benoitberanger wants to merge 9 commits into
Open
Conversation
and added a description in the nifti heater
nothing is written on disk added some help
- this solves the error when 'nVoxels <= nVolumes' - tapas_physio_pca now complete rewrite - tapas_physio_create_noise_rois_regressors adapted for the new tapas_physio_pca - more logs in tapas_physio_create_noise_rois_regressors - 'different orientation" warning is now a normal log message
variables names correspond to spm_regions function tapas_physio_create_noise_rois_regressors adapted
warnings -> simple logs more help / comments
12 tasks
Contributor
Author
|
TODO
|
Member
|
Dear Benoit, My apologies, but I didn't have enough time to include your PR into the upcoming TAPAS release. I am still working with Johanna Bayer on the summer project to improve PhysIO, but it will take a couple of weeks to overhaul everything. I will let you know once we integrate your PR. All the best, |
number of voxels remaining in the ROI is counted at every step, helping for debugging
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR responds to #162
CHANGE : tapas_physio_pca
This function now uses the covariance matrix instead of the matrix itself.
This strategy is inpired by spm_regions function.
CHANGE : tapas_physio_create_noise_rois_regressors
The function have minor modifications due to the PCA rework.
However :
NEW : function tapas_physio_interactive_noiseROI_mask
This function will load a mask and display it using spm_orthviews, apply a threshold + erosion then display the result using an overlay.
The noiseROI volume (the overlay) remains in memory, no volume is written. Maybe a feature to add ?
A panel is added on spm_orthviews so the threshold and erosion level can be changed and the result visualized dynamicaly.
DELETE : tapas_physio_pca_test
The function have been removed, since the approach have changed (covariance matrix)
This is a discussion the to have with the devs (@mrikasper). I'm opened to keep the test function, even though it needs to be complitly reworked to keep the old appreach and the new.