Unrealistic values with --force-beam and --vectorize #180

Activity

1. HannoSpreeuw commented on Nov 27, 2025

   

   HannoSpreeuw

   on Nov 27, 2025

   Last edited by HannoSpreeuw

   Collaborator

   More actions

   I think I found the source of the problem.

   To derive the peak brightness, tweaked moments takes the pixel value at the rounded barycenter position and extrapolates that to the barycenter position.
   That extrapolation can be based on the (forced) beam or based on the measured source shape. It is an extrapolation over a subtended angle at the subpixel level.

   In some edge cases the rounded barycenter positon is not an island pixel.
   In that case, tweaked moments is still applied, but the maximum pixel value and the position of that pixel are used to extrapolate from. This appeared to work well.

   All the problems seem to occur when the island of pixels is relatively wide, when the rounded barycenter position is not an island pixel and the maximum pixel position is far from the island barycenter. That is rare, but can occur with an extended source with a relatively flat brightness distribution. The extrapolation then leads to incredibly large derived peak brightness, but likely only for forced beam measurements: for free shape the measured axes will be large such that the extrapolation will not lead to large values.

   I guess the answer should be that we should not apply "tweaked moments" when the rounded barycenter position does not correspond to an island pixel and use fudge_max_pix times the maximum pixel value instead.

   @AntoniaR thanks for catching this, this is a serious error, which was not caught by our extensive regression tests with up to 167,000 artificial sources. But these sources were "well formed", such that the error did not occur.

   Perhaps I could include this image in a unit test, but I am not sure how to implement that without ground truth data.
   Well, the unit test should perhaps assert that no derived peak brightness should be, say, 20% higher than the maximum pixel value over the entire image, but that would be a pretty coarse test.

   Some data for my future reference, selecting island data for derived peak brightnesses > 100 Jy/beam, from this command: pyse GRB201006A_final_2min_srcs-t0021-image-pb.fits --force-beam --vectorized --back-size-x 50 --back-size-y 50:

   Number of detected sources = 1038
   
   peak =  1054.2947525880033  , maxi =  0.030075108632445335  , basevalue =  0.030075108632445335  , mask.any() =  False  , min_width =  16  , deltax =  3.0591402833020833  , deltay =  7.749962332556443  , smin =  1.8212668942844181  , smaj =  2.4119618032265238  , theta =  0.25895872745169685 
   
   
   peak =  148826.42171051877  , maxi =  0.047940585762262344  , basevalue =  0.047940585762262344  , mask.any() =  False  , min_width =  11  , deltax =  -8.526144236439507  , deltay =  -0.4288498322058176  , smin =  1.8212668942844181  , smaj =  2.4119618032265238  , theta =  0.25895872745169685 
   
   
   peak =  112.99034466457526  , maxi =  0.09484915435314178  , basevalue =  0.09484915435314178  , mask.any() =  False  , min_width =  14  , deltax =  0.7388329380896614  , deltay =  7.336954235600766  , smin =  1.8212668942844181  , smaj =  2.4119618032265238  , theta =  0.25895872745169685 
   
   
   peak =  8069.562513688345  , maxi =  0.030813246965408325  , basevalue =  0.030813246965408325  , mask.any() =  False  , min_width =  5  , deltax =  -6.501387096276856  , deltay =  -4.541582242520785  , smin =  1.8212668942844181  , smaj =  2.4119618032265238  , theta =  0.25895872745169685 
   
   
   peak =  57032.37147844775  , maxi =  0.04439084231853485  , basevalue =  0.04439084231853485  , mask.any() =  False  , min_width =  5  , deltax =  8.401070859081242  , deltay =  -1.1798297518388456  , smin =  1.8212668942844181  , smaj =  2.4119618032265238  , theta =  0.25895872745169685 
   
   
   peak =  34119236030.69715  , maxi =  0.03593478351831436  , basevalue =  0.03593478351831436  , mask.any() =  False  , min_width =  15  , deltax =  -11.704237973690063  , deltay =  3.633650425578578  , smin =  1.8212668942844181  , smaj =  2.4119618032265238  , theta =  0.25895872745169685 
   
   
   peak =  4.799304561372789e+17  , maxi =  0.040669266134500504  , basevalue =  0.040669266134500504  , mask.any() =  False  , min_width =  10  , deltax =  -14.637748757572489  , deltay =  5.764220347858702  , smin =  1.8212668942844181  , smaj =  2.4119618032265238  , theta =  0.25895872745169685 
   
2. HannoSpreeuw

   added a sub-issue on Nov 29, 2025

   • Add regression test to cross-check against non-vectorized output. #182
3. HannoSpreeuw

   closed this as completedin #184on Nov 30, 2025
4. AntoniaR commented on Dec 2, 2025

   

   AntoniaR

   on Dec 2, 2025

   Contributor

   More actions

   Is this now in the latest version when I update with pip install?
5. HannoSpreeuw commented on Dec 2, 2025

   

   HannoSpreeuw

   on Dec 2, 2025

   Collaborator

   More actions

   Coming up....I'd like to include #181 as well in a new release.
   As soon as that MR is settled, I will release.
   So within hours or within minutes.
6. AntoniaR commented on Dec 2, 2025

   

   AntoniaR

   on Dec 2, 2025

   Contributor

   More actions

   Ah - perfect! I was just querying that issue 🙂
7. HannoSpreeuw

   added a commit that references this issue on Dec 13, 2025

   Restrict "tweaked moments" for "free shape"

   ...

   16eed05