feat: Update UASLAgentService proto definitions - #14
Conversation
Migrated apis from airway_agent service 2025/mvp2 support
There was a problem hiding this comment.
Pull request overview
This PR updates UASLAgentService proto definitions to migrate APIs from the former airway agent service and add 2025/mvp2 support for UASL reservation retrieval, UASL registration, and assigned-UASL lookup.
Changes:
- Added UASL reservation list/detail RPCs and associated request/response messages.
- Added UASL registration RPC/message schema (including waypoint/segment and external system linkage fields).
- Added
GetAssignedUaslRPC and response schema for assigned section details.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| string flight_purpose = 3; | ||
| // 予約ステータス | ||
| Status status = 4; | ||
| // 見積もり合計金額(税込) |
| // RFC3339形式の日時文字列 | ||
| optional google.protobuf.Timestamp start_at = 4; | ||
| // RFC3339形式の日時文字列 |
| rpc GetAssignedUasl(GetAssignedUaslRequest) returns (GetAssignedUaslResponse){ | ||
| option (google.api.http) = { | ||
| // GETリクエストとして定義。クエリパラメータで uasl_id を指定する形式となります。 | ||
| // 例: /uasl_agent/get_assigned_uasl?uasl_id.uasl_systems_uasl_id=123&uasl_id.uasl_system_id=1 |
| // ただし、外部システムの既存航路に接続するときは設定しない。 | ||
| optional string external_point_id = 4; | ||
| // information related to create uasl point | ||
| repeated UaslPointSegment uasl_point_segment = 5; |
| } | ||
| message GetAssignedUaslResponse { | ||
| // 管理組織ID | ||
| int64 organization_id = 1; |
| RESERVATION_STATUS_UNSPECIFIED = 0; | ||
| // 予約完了 | ||
| RESERVATION_STATUS_RESERVED = 1; | ||
| // 予約失敗 |
HarutakaMatsumoto
left a comment
HarutakaMatsumoto
left a comment
There was a problem hiding this comment.
I have reviewed this pull request in the middle.
Please check it.
| // repeated string uasl_section_ids = 5; | ||
| // } | ||
| enum Standard { | ||
| ALTITUDE_ATTR_UNSPECIFIED = 0 ; |
There was a problem hiding this comment.
This does not conform to https://protobuf.dev/programming-guides/style/#enums.
Please follow that guide.
| // } | ||
| enum Standard { | ||
| ALTITUDE_ATTR_UNSPECIFIED = 0 ; | ||
| RELATIVE= 1; // 離陸地点を基準とする相対高度。ItemParameterにより使用可 |
There was a problem hiding this comment.
This protocol does not have ItemParameter.
Remove ItemParameter.
| // UASL予約ID | ||
| optional string uasl_reservation_id = 2; | ||
| // 予約開始日時 | ||
| optional google.protobuf.Timestamp start_at = 6; |
There was a problem hiding this comment.
| // 予約開始日時 | ||
| optional google.protobuf.Timestamp start_at = 6; | ||
| // 予約終了日時 | ||
| optional google.protobuf.Timestamp end_at = 8; |
There was a problem hiding this comment.
| // 見積もり合計金額(税込) | ||
| optional int32 total_amount = 5; | ||
| // 予約確定日時（確定していない場合は空） | ||
| google.protobuf.Timestamp reserved_at = 6; |
There was a problem hiding this comment.
| // 使用種別 | ||
| PortUsageType usage_type = 3; | ||
| // ポート予約開始時刻 | ||
| google.protobuf.Timestamp start_at = 4; |
There was a problem hiding this comment.
| // ポート予約開始時刻 | ||
| google.protobuf.Timestamp start_at = 4; | ||
| // ポート予約終了時刻 | ||
| google.protobuf.Timestamp end_at = 5; |
There was a problem hiding this comment.
| string reasons = 5; | ||
|
|
||
| enum FailureType { | ||
| FAILURE_TYPE_UNSPECIFIED = 0; // null/OK |
There was a problem hiding this comment.
This enumeration type includes "OK," so the name "Failure*" is inappropriate.
Please rename it.
| AircraftInfo aircraft_info = 2; | ||
| // 適合性評価結果 true : 適合性評価結果OK false: 適合性評価結果NG | ||
| bool evaluation_results = 3; | ||
| // 適合性評価結果がNGの場合の種別 |
There was a problem hiding this comment.
This field can be "OK", so this comment is incorrect.
Please remove "NGの場合".
| bool evaluation_results = 3; | ||
| // 適合性評価結果がNGの場合の種別 | ||
| FailureType type = 4; | ||
| // 適合性評価結果がNGの場合の詳細 |
There was a problem hiding this comment.
I think it is OK that this field has a value even if type is OK like https://github.com/grpc/grpc/blob/59fe7c77170d1164eb3a7b0837cda29d42677dce/src/proto/grpc/status/status.proto#L87.
Migrated apis from airway_agent service
2025/mvp2 support