Capture individual Binance trades - #60
Open
tradingexpert wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tradeWebSocket messages alongside depthBinanceIndividualTraderecords throughindividual_trades()/fapi/v1/tradesrecorder forisRPITrade, overlap auditing, and recovery evidenceWhy both individual-trade sources
The real-time WebSocket
@tradestream is the primary individual-trade evidence. It avoids the information loss inaggTradeand the rolling-window risk of REST-only polling. The REST endpoint contributes the additionalisRPITradefield and independent reconciliation evidence.aggTradeis retained for comparison, never as a substitute for individual trades.Live testing rejected the initial REST-only design after observed BTCUSDT/ETHUSDT bursts rolled beyond the 1,000-row response window. The implementation and documentation now state that limitation directly.
Live validation
A two-symbol live smoke run captured:
Verification
python -m ruff check .python -m pytest --cov=ordersim --cov-report=term-missingpython -m build --outdir /tmp/ordersim-dist-cea0861python -m twine check /tmp/ordersim-dist-cea0861/*