[FIX/ENH] VOF HBN changes#202
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new derived scalar in AFQ.tasks.data to compute a T1w-over-log(b0) image intended as an R1 proxy, and wires it into the default data task plan so it can be produced as part of standard runs.
Changes:
- Added a new
t1w_over_log_b0calculation task that computesT1w / log(mean b0)after resampling T1w into b0 space. - Registered the new task in
get_data_planso it runs alongside existing scalar generation (e.g.,t1w_over_b0).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
AFQ/tasks/tissue.py:126
- The ValueError message is now outdated: it doesn’t mention the newly supported option
'multiaxial+brainchop+synthseg', which can confuse users when they pass an invalid value.
raise ValueError(
"pve must be a PVEImage, PVEImages, 'synthseg', or 'multiaxial+brainchop'"
)
Collaborator
Author
|
@arokem this is ready for review / merge |
arokem
reviewed
Jul 21, 2026
| ) | ||
|
|
||
|
|
||
| def merge_PVEs(PVE_a, PVE_b): |
Member
There was a problem hiding this comment.
Any chance to add a test of this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes these changes: