Mode the Displaysettings config in the Preferences dialog and clean duplicate code - #359
Merged
Merged
Conversation
Make it implements ProfileEditPanel, so that we can later use it in a config page. Move the visitor to its own class, and wrap the panel itself in a scrollpane.
With a manager that can deal with a collection of settings.
This is important, as we will load a DisplaySettings from a TrackMate file and want to use this instance. We also want it to appear in the config page and the modifications to be done on this one.
which is set to edit the DisplaySettings instance it was created with.
Now everything is done in the Preferences dialog. The readUserDefault() method now returns the last settings used and configured by the user in the dialog.
We moved everything to the config-ui artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the DisplaySettings configuration into the Preferences dialog and cleans up duplicate code by migrating to the config-ui artifact.
Changes
DisplaySettingsimplementStyle<DisplaySettings>and refactoredDisplaySettingsPanelProfileEditPanelfor use in the preferences dialogreadUserDefault()to return last user-configured settings from dialogStats