Skip to content

Correctly create wheels for linux, musllinux, and musllinux-cross#314

Merged
jo-sm merged 1 commit into
developfrom
fix-wheel-publishing
Jul 3, 2026
Merged

Correctly create wheels for linux, musllinux, and musllinux-cross#314
jo-sm merged 1 commit into
developfrom
fix-wheel-publishing

Conversation

@jo-sm

@jo-sm jo-sm commented Jul 3, 2026

Copy link
Copy Markdown
Member

This PR fixes wheel artifact creation for linux, musllinux, and musllinux-cross, so that all expected Python versions are correctly published.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 37d344d1-ac01-4be8-ba9d-092e996fcd84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-wheel-publishing

Comment @coderabbitai help to get the list of available commands.

@jo-sm jo-sm force-pushed the fix-wheel-publishing branch from a939753 to 2d9e756 Compare July 3, 2026 09:16

@konstantinoscs konstantinoscs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One thing is that we could/should build is a post-publish job that checks that the wheels/ dir contains all the files that should be there. (it's my understanding of the original problem that we were skipping some of them)

@jo-sm jo-sm merged commit c7afcbf into develop Jul 3, 2026
28 checks passed
@jo-sm jo-sm deleted the fix-wheel-publishing branch July 3, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants