Skip to content

fix: milk tag containing nothing - #54

Merged
JaronZ merged 2 commits into
mainfrom
fix-c-milk-tag
Aug 12, 2025
Merged

fix: milk tag containing nothing#54
JaronZ merged 2 commits into
mainfrom
fix-c-milk-tag

Conversation

@JaronZ

@JaronZ JaronZ commented Aug 12, 2025

Copy link
Copy Markdown
Member

Resolves #52

@JaronZ JaronZ added this to the Forgeworks 1.4.1 milestone Aug 12, 2025
@JaronZ JaronZ self-assigned this Aug 12, 2025
Copilot AI review requested due to automatic review settings August 12, 2025 10:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves issue #52 by creating a new milk fluid tag file that was apparently missing or empty. The change adds a comprehensive collection of milk-related fluid identifiers from various Minecraft mods.

  • Adds a new milk.json tag file with 16 different milk-related fluid entries
  • Includes fluids from vanilla Minecraft and popular mods like Create, CreateFood, and ExtraDelight
  • Sets the replace flag to true, indicating this tag completely replaces any existing definitions

Comment thread packages/forgeworks/src/data/c/tags/fluid/milk.json Outdated
@JaronZ
JaronZ merged commit 2d86804 into main Aug 12, 2025
3 checks passed
@JaronZ
JaronZ deleted the fix-c-milk-tag branch August 12, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] Milk tag has no fluids

2 participants