Skip to content

Added two new features to facetoface - #3

Open
stgabhas wants to merge 27 commits into
totara:masterfrom
stgabhas:master
Open

Added two new features to facetoface#3
stgabhas wants to merge 27 commits into
totara:masterfrom
stgabhas:master

Conversation

@stgabhas

Copy link
Copy Markdown

Hello,
I have added two new features:

  1. Disable Auto Enrollment of user xx days before a session starts, (when a user is on wait-list due to over booking)
  2. Disable New Enrollment of user xx days before a session starts.

Thank you.

Abhas Bhatt added 2 commits May 28, 2013 10:21
@stgabhas

Copy link
Copy Markdown
Author

I have updated the code, as you commented. Please check and let me know.
Thank you.
Abhas

Comment thread lib.php Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-add line deleted here

@aly

aly commented May 30, 2013

Copy link
Copy Markdown
Contributor

Few more comments, once those are fixed I'll test it out :-)

…Database calls that is made in the renderer
@stgabhas

Copy link
Copy Markdown
Author

I have pushed a new update as according to your input. (Except for the calling of DB in renderer).
About the Day 0 in the enrollment, I have added an explanation that Day 0 means the same day the session starts.
Waiting for your comments.
Thank you.

Comment thread db/upgrade.php Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra new line

Comment thread db/install.xml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indenting of this line

@aly

aly commented Jun 4, 2013

Copy link
Copy Markdown
Contributor

Hopefully my comments about the Database calls is helpful. If you have any questions let me know.

Thanks,
Alastair

Abhas Bhatt added 3 commits June 5, 2013 11:12
…pace, extra lines, and indentation. The css 100% width on styles.php is not working, and I am still working on the database calls mentioned in the last comment
@stgabhas

stgabhas commented Jun 5, 2013

Copy link
Copy Markdown
Author

I have updated the code as instructed. And I have removed a couple of database calls from renderer.php and lib.php. Please refer to todays commit.
Thank you.

@stgabhas

stgabhas commented Jun 5, 2013

Copy link
Copy Markdown
Author

The issue with 100% width on styles.css has been fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants