New completion condition: Session is over - #2
Open
emeneo wants to merge 7 commits into
Open
Conversation
added 7 commits
June 1, 2012 11:45
This reverts commit 5a50fbdd2362483648e4036c97eb6f3309759c81.
Contributor
|
Hi David, Moodle currently supports multiple database types. I have noticed you have used mysql specific database functions. These need to be updated before this can be merged into core Face-to-face. Once this has been done I can do some testing and let you know if I find any other problems. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
This condition is a thick box available if the Activity completion selected is : Show ...
The completion condition are: A session of the module facetoface must be over with people still attendee to this session and the module must have the condition enable in the setting.
The verification of thoses condition and the completion happen when the cron.php of facetoface is launch, because my idea was to do with the 'schedule task' of windows a daily update of the database by running the admin/cron.php everyday.
My modification are in the lib.php and the mod_form.php. I had to add a field completionsession in facetoface table, so that why I modify the db/upgrade.php. Finally I modify the view.php of facetoface just to quickly enable the condition require view for facetoface.
Let me know what do you think and if it is working for you or not.
Thanks