Skip to content

New completion condition: Session is over - #2

Open
emeneo wants to merge 7 commits into
totara:masterfrom
emeneo:master
Open

New completion condition: Session is over#2
emeneo wants to merge 7 commits into
totara:masterfrom
emeneo:master

Conversation

@emeneo

@emeneo emeneo commented Jun 1, 2012

Copy link
Copy Markdown

Hello

This condition is a thick box available if the Activity completion selected is : Show ...

The completion condition are: A session of the module facetoface must be over with people still attendee to this session and the module must have the condition enable in the setting.

The verification of thoses condition and the completion happen when the cron.php of facetoface is launch, because my idea was to do with the 'schedule task' of windows a daily update of the database by running the admin/cron.php everyday.

My modification are in the lib.php and the mod_form.php. I had to add a field completionsession in facetoface table, so that why I modify the db/upgrade.php. Finally I modify the view.php of facetoface just to quickly enable the condition require view for facetoface.

Let me know what do you think and if it is working for you or not.
Thanks

@aly

aly commented Jun 7, 2012

Copy link
Copy Markdown
Contributor

Hi David,

Moodle currently supports multiple database types. I have noticed you have used mysql specific database functions. These need to be updated before this can be merged into core Face-to-face. Once this has been done I can do some testing and let you know if I find any other problems.

Cheers,
Alastair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants