Skip to content

ci: fix false positives in broken link checker - #1984

Open
Tnalxmsk wants to merge 1 commit into
toss:mainfrom
Tnalxmsk:fix/broken-link-checker-false-positives
Open

ci: fix false positives in broken link checker#1984
Tnalxmsk wants to merge 1 commit into
toss:mainfrom
Tnalxmsk:fix/broken-link-checker-false-positives

Conversation

@Tnalxmsk

@Tnalxmsk Tnalxmsk commented Aug 31, 2026

Copy link
Copy Markdown

Overview

Closes #1983.

The scheduled Broken link checker reports three false positives in the
latest workflow run:

  • Two npm package links return HTTP 403 because npm serves a Cloudflare
    challenge to automated requests.
  • The TanStack Query v5 installation link returns HTTP 308 and redirects
    to its canonical latest URL.

This keeps the scheduled workflow red even though all target resources exist.

Changes

  • Exclude npmjs.com URLs because automated requests cannot validate them
    reliably.
  • Replace the redirected TanStack Query URL with its canonical URL so it
    remains covered by the checker.
  • Keep the English and Korean migration documentation aligned.

Verification

  • Formatting check passed for all changed files.
  • ESLint passed for both changed MDX files.
  • The canonical TanStack Query URL returns HTTP 200 without redirects.
  • Because the checker crawls the production site, the production-only legacy
    URL was temporarily excluded during verification:
    • 8,721 links found
    • 8,548 links excluded
    • 0 broken links

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@coauthors

coauthors Bot commented Aug 31, 2026

Copy link
Copy Markdown

People can be co-author:

Candidate Reasons Count Add this as commit message
@Tnalxmsk #1984 1 Co-authored-by: Tnalxmsk <113881311+Tnalxmsk@users.noreply.github.com>

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@Tnalxmsk is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88e831c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Broken link checker fails due to false positives

1 participant