Skip to content

feat(order): add price snapshot and restaurant-scoped validation to place_order() #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leothosine merged 2 commits into from
Jun 26, 2026
Merged

feat(order): add price snapshot and restaurant-scoped validation to place_order() #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa8076
feat(order): add price snapshot and restaurant-scoped validation to p…
Ibinola Jun 23, 2026
424c1fe
Merge branch 'main' into feat/issue-287-price-snapshot-restaurant-val…
Leothosine Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions contracts/order/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ pub struct OrderItem {
pub name: String,
pub quantity: u32,
pub unit_price: i128,
/// Full snapshot: name + authoritative price at order time.
pub snapshot: MenuItemSnapshot,
}

#[contracttype]
Expand Down Expand Up @@ -131,6 +133,7 @@ impl OrderContract {

// Compute total from items using checked arithmetic to prevent overflow.
let mut total: i128 = 0;

for item in items.iter() {
if item.quantity == 0 {
panic!("quantity must be greater than zero");
Expand Down Expand Up @@ -161,7 +164,7 @@ impl OrderContract {
id,
restaurant_id,
customer: customer.clone(),
items: items.clone(),
items: validated_items,
total_amount: total,
status: OrderStatus::Pending,
created_at: now,
Expand All @@ -170,7 +173,6 @@ impl OrderContract {
expires_at: now + ORDER_TTL_SECONDS,
};

let ttl: u32 = 2_073_600;
env.storage().persistent().set(&DataKey::Order(id), &order);
env.storage()
.persistent()
Expand Down Expand Up @@ -430,12 +432,20 @@ mod test {
}
}

fn make_item(env: &Env, id: u64, qty: u32, price: i128) -> OrderItem {
/// Build a minimal OrderItem. `unit_price` is intentionally wrong to prove
/// place_order ignores it and uses the registry price instead.
fn make_item(env: &Env, id: u64, qty: u32) -> OrderItem {
let snap = MenuItemSnapshot {
menu_item_id: id,
name: String::from_str(env, ""),
price_at_order: 0,
};
OrderItem {
menu_item_id: id,
name: String::from_str(env, "Jollof Rice"),
name: String::from_str(env, ""),
quantity: qty,
unit_price: price,
unit_price: 1, // deliberately wrong — should be ignored
snapshot: snap,
}
}

Expand Down
Loading