Table cells have to reset their own shape, not only the parts being changed - #301
Merged
Merged
Conversation
…hanged The ruled-card table shipped with row rules that stop at the column boundary and curve away instead of crossing the table. Same class of miss as the fill in #300, one property along. The reader styles cells as standalone chips — a fill and a corner radius of their own — and both survive any rule that does not name them. #300 added background:transparent and stopped there, so border-radius:8px stayed on every cell. Under border-collapse:separate each cell is its own box, so a border-bottom on it is rounded off at both ends, and two rounded ends meeting in the middle read as a break in the rule. Counting gaps along a row rule on a two-column table: 3 with the radius left in place, 0 without it. components.md now says to reset the cell's shape rather than the parts being changed, and names both properties. The card carries the radius; the cells do not. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
PreviewOpen this: https://pr-301-tdoc-preview.jyshi1107.workers.dev/d/conway-life/v/2 This link is unique to this PR. New commits update the same URL. It is not tdoc.dev. Preview has no Durable Object — concurrent comments use the KV fallback. Data expires in 14 days. |
serenakeyitan
added a commit
that referenced
this pull request
Aug 28, 2026
Two things about the table treatment from #300. The radius is gone from the contract and from all four styles. A rounded card competes with the figures around it, and on the cells it was worse than decorative — that was the break in the row rules #301 chased: under border-collapse:separate each cell is its own box, so a rounded one truncates the rule at both ends and two of those meeting in the middle read as a gap rather than a continuous edge. default, paper and editorial carried rx:12, rx:6 and rx:10; all four now say square, which is what technical already said. The header was set at 13.5px in the muted ink — smaller and greyer than the body, so it read as a quieter row rather than a different kind of row. It now takes the style's label-type token, which every entry already declares, over its own rule a step stronger than the row rules beneath it. A table header is a label, so this is the token doing the job it exists for rather than a new rule invented for tables. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ruled-card table shipped with row rules that stop at the column boundary and curve away instead of crossing the table.
Same class of miss as the fill in #300, one property along. The reader styles cells as standalone chips — a fill and a corner radius of their own — and both survive any rule that does not name them. #300 added
background: transparentand stopped there, soborder-radius: 8pxstayed on every cell. Underborder-collapse: separateeach cell is its own box, so aborder-bottomon it gets rounded off at both ends, and two rounded ends meeting in the middle read as a break in the rule.Measured on a two-column table, counting gaps along a row rule:
border-radius: 8pxborder-radius: 0components.mdnow says to reset the cell's shape rather than the parts being changed, and names both properties. The card carries the radius; the cells do not.Verified on the published page: every row rule crosses the full 665px table with zero gaps.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xw9Mt3rV3ujnejPr41pqvz