Switch rubocop CI output to GitHub annotations format - #1012
Merged
Conversation
Replace `--format simple` with `--format github` so rubocop offenses appear as inline annotations on PR diffs.
Contributor
Author
|
@bbatsov do you want me to create changelog entries for housekeeping items like this? |
2 tasks
Contributor
Author
|
@bbatsov Quick question — do internal CI/housekeeping changes like this need a CHANGELOG entry, or is that only for user-facing changes? |
Contributor
|
@mattmenefee there is no need to create any CHANGELOG entry for this. |
AlfonsoUceda
approved these changes
Mar 25, 2026
AlfonsoUceda
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mattmenefee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--format simplewith--format githubin the CI rubocop job so offenses appear as inline annotations on PR diffsTest plan
--format github