Skip to content

Switch rubocop CI output to GitHub annotations format - #1012

Merged
AlfonsoUceda merged 2 commits into
toptal:masterfrom
mattmenefee:github-rubocop-comments
Mar 25, 2026
Merged

Switch rubocop CI output to GitHub annotations format#1012
AlfonsoUceda merged 2 commits into
toptal:masterfrom
mattmenefee:github-rubocop-comments

Conversation

@mattmenefee

@mattmenefee mattmenefee commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace --format simple with --format github in the CI rubocop job so offenses appear as inline annotations on PR diffs

Test plan

  • CI rubocop job runs successfully with --format github
  • Rubocop offenses (if any) appear as inline annotations on the PR diff

Replace `--format simple` with `--format github` so rubocop
offenses appear as inline annotations on PR diffs.
@mattmenefee
mattmenefee requested a review from a team as a code owner March 18, 2026 15:52
@mattmenefee

Copy link
Copy Markdown
Contributor Author

@bbatsov do you want me to create changelog entries for housekeeping items like this?

@mattmenefee

Copy link
Copy Markdown
Contributor Author

@bbatsov Quick question — do internal CI/housekeeping changes like this need a CHANGELOG entry, or is that only for user-facing changes?

@AlfonsoUceda

Copy link
Copy Markdown
Contributor

@mattmenefee there is no need to create any CHANGELOG entry for this.

@AlfonsoUceda AlfonsoUceda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattmenefee

@AlfonsoUceda
AlfonsoUceda merged commit 619f895 into toptal:master Mar 25, 2026
13 checks passed
@mattmenefee
mattmenefee deleted the github-rubocop-comments branch March 25, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants