Conversation
What was broken PM users and opportunity creators could miss email notifications when a copilot applied for an opportunity. Root cause The apply handler resolved PM role subjects and the opportunity creator inline with application creation, so recipient lookup failures could suppress all application emails. It also reused the role subject list directly and did not wait for email bus event submissions. What was changed Added a dedicated notification flow that resolves PM role subjects and the opportunity creator, filters recipients without emails, deduplicates recipients by email, logs lookup or send failures without blocking the application response, includes the applicant handle, and awaits external email bus event submissions. Any added/updated tests Added unit coverage for PM and creator notification events, including the fallback path where the creator is still notified if PM role lookup fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
PM users and opportunity creators could miss email notifications when a copilot applied for an opportunity.
Root cause
The apply handler resolved PM role subjects and the opportunity creator inline with application creation, so recipient lookup failures could suppress all application emails. It also reused the role subject list directly and did not wait for email bus event submissions.
What was changed
Added a dedicated notification flow that resolves PM role subjects and the opportunity creator, filters recipients without emails, deduplicates recipients by email, logs lookup or send failures without blocking the application response, includes the applicant handle, and awaits external email bus event submissions.
Any added/updated tests
Added unit coverage for PM and creator notification events, including the fallback path where the creator is still notified if PM role lookup fails.
Validation run:
Full npm test was attempted with DB_SCHEMA_NAME=public, but it stops in npm run lint on pre-existing unrelated lint errors across legacy copilot/project files before reaching DB, ES, or mocha.