Conversation
What was broken Task copilot payments for regular, TAAS, and Topgear challenges were generated in On Hold (Admin) status instead of Owed. Root cause Task payment status resolution only treated TAAS winner payments as Owed. Copilot payments use the COPILOT_PAYMENT category, so the generic non-TAAS task fallback forced them to On Hold (Admin). What was changed Task payment status resolution now treats copilot payment categories as Owed while preserving the existing On Hold (Admin) default for other non-TAAS task payments. Latest-dev type and test expectations that blocked lint/test validation were also aligned without changing runtime payment behavior. Any added/updated tests Added challenge-service coverage for regular, TAAS, and Topgear task copilot payments resolving to Owed. Updated existing latest-dev specs/type assertions so lint and the full Jest suite pass on the branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Task copilot payments for regular, TAAS, and Topgear challenges were generated in On Hold (Admin) status instead of Owed.
Root cause
Task payment status resolution only treated TAAS winner payments as Owed. Copilot payments use the COPILOT_PAYMENT category, so the generic non-TAAS task fallback forced them to On Hold (Admin).
What was changed
Task payment status resolution now treats copilot payment categories as Owed while preserving the existing On Hold (Admin) default for other non-TAAS task payments.
Latest-dev type and test expectations that blocked lint/test validation were also aligned without changing runtime payment behavior.
Any added/updated tests
Added challenge-service coverage for regular, TAAS, and Topgear task copilot payments resolving to Owed.
Updated existing latest-dev specs/type assertions so lint and the full Jest suite pass on the branch.
Validation