Skip to content

PM-4151: guard MM provisional review fallback #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 4 commits into from
Jun 22, 2026
Merged

PM-4151: guard MM provisional review fallback #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c367f65
PM-4151: suppress incomplete MM final export data
jmgasper Jun 19, 2026
f9caad4
PM-4151: guard MM final score fallback
jmgasper Jun 19, 2026
e3be399
PM-4151: ignore failed MM score runs
jmgasper Jun 22, 2026
f7b0459
PM-4151: guard MM provisional review fallback
jmgasper Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 51 additions & 12 deletions sql/reports/challenges/submitters.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
WITH challenge_context AS (
SELECT
c.id,
(ct.name = 'Marathon Match') AS is_marathon_match
(ct.name = 'Marathon Match') AS is_marathon_match,
(c.status = 'COMPLETED') AS is_completed
FROM challenges."Challenge" AS c
JOIN challenges."ChallengeType" AS ct
ON ct.id = c."typeId"
Expand All @@ -17,17 +18,46 @@ submission_metrics AS (
s."finalScore"::double precision,
s."initialScore"::double precision
) AS standard_score,
provisional_review.provisional_score,
COALESCE(
final_review."aggregateScore",
s."finalScore"::double precision
) AS final_score_raw
CASE
WHEN s.status IN (
'FAILED_SCREENING',
'FAILED_REVIEW',
'FAILED_CHECKPOINT_SCREENING',
'FAILED_CHECKPOINT_REVIEW',
'DELETED'
) THEN NULL
WHEN provisional_review.has_provisional_review THEN CASE
WHEN provisional_review.provisional_score >= 0 THEN provisional_review.provisional_score
ELSE NULL
END
WHEN s."initialScore"::double precision >= 0 THEN s."initialScore"::double precision
ELSE NULL
END AS provisional_score,
CASE
WHEN NOT cc.is_completed THEN NULL
WHEN s.status IN (
'FAILED_SCREENING',
'FAILED_REVIEW',
'FAILED_CHECKPOINT_SCREENING',
'FAILED_CHECKPOINT_REVIEW',
'DELETED'
) THEN NULL
WHEN final_review.has_final_review THEN CASE
WHEN final_review."aggregateScore" >= 0 THEN final_review."aggregateScore"
ELSE NULL
END
WHEN s."finalScore"::double precision >= 0 THEN s."finalScore"::double precision
ELSE NULL
END AS final_score_raw,
cc.is_completed
FROM challenge_context AS cc
JOIN reviews."submission" AS s
ON s."challengeId" = cc.id
AND s."memberId" IS NOT NULL
LEFT JOIN LATERAL (
SELECT rs."aggregateScore"
SELECT
TRUE AS has_final_review,
rs."aggregateScore"
FROM reviews."reviewSummation" AS rs
WHERE rs."submissionId" = s.id
AND COALESCE(rs."isFinal", TRUE) = TRUE
Expand All @@ -36,7 +66,9 @@ submission_metrics AS (
LIMIT 1
) AS final_review ON TRUE
LEFT JOIN LATERAL (
SELECT rs."aggregateScore" AS provisional_score
SELECT
TRUE AS has_provisional_review,
rs."aggregateScore" AS provisional_score
FROM reviews."reviewSummation" AS rs
WHERE rs."submissionId" = s.id
AND rs."isProvisional" IS TRUE
Expand Down Expand Up @@ -73,9 +105,12 @@ mm_latest_submission_scores AS (
sm."memberId",
sm.provisional_score AS provisional_score_raw,
sm.final_score_raw,
COALESCE(sm.final_score_raw, sm.provisional_score) AS effective_score_raw,
sm.is_completed,
sm.submission_timestamp
FROM submission_metrics AS sm
WHERE
sm.provisional_score IS NOT NULL
OR sm.final_score_raw IS NOT NULL
ORDER BY
sm."memberId",
sm.submission_timestamp DESC NULLS LAST,
Expand All @@ -93,13 +128,13 @@ mm_ranked_scores AS (
ELSE ROUND(mlss.final_score_raw::numeric, 2)
END AS "finalScore",
CASE
WHEN mlss.effective_score_raw IS NULL THEN NULL
ELSE ROW_NUMBER() OVER (
WHEN mlss.is_completed AND mlss.final_score_raw IS NOT NULL THEN ROW_NUMBER() OVER (
ORDER BY
mlss.effective_score_raw DESC NULLS LAST,
mlss.final_score_raw DESC NULLS LAST,
mlss.submission_timestamp ASC NULLS LAST,
mlss."memberId" ASC
)
ELSE NULL
END AS "finalRank"
FROM mm_latest_submission_scores AS mlss
)
Expand Down Expand Up @@ -177,6 +212,10 @@ ORDER BY
WHEN sm.is_marathon_match THEN mrs."finalRank"
ELSE NULL
END ASC NULLS LAST,
CASE
WHEN sm.is_marathon_match AND mrs."finalRank" IS NULL THEN mrs."provisionalScore"
ELSE NULL
END DESC NULLS LAST,
CASE
WHEN sm.is_marathon_match THEN NULL
ELSE sms."submissionScore"
Expand Down
63 changes: 51 additions & 12 deletions sql/reports/challenges/valid-submitters.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
WITH challenge_context AS (
SELECT
c.id,
(ct.name = 'Marathon Match') AS is_marathon_match
(ct.name = 'Marathon Match') AS is_marathon_match,
(c.status = 'COMPLETED') AS is_completed
FROM challenges."Challenge" AS c
JOIN challenges."ChallengeType" AS ct
ON ct.id = c."typeId"
Expand All @@ -17,11 +18,38 @@ submission_metrics AS (
s."finalScore"::double precision,
s."initialScore"::double precision
) AS standard_score,
provisional_review.provisional_score,
COALESCE(
final_review."aggregateScore",
s."finalScore"::double precision
) AS final_score_raw,
CASE
WHEN s.status IN (
'FAILED_SCREENING',
'FAILED_REVIEW',
'FAILED_CHECKPOINT_SCREENING',
'FAILED_CHECKPOINT_REVIEW',
'DELETED'
) THEN NULL
WHEN provisional_review.has_provisional_review THEN CASE
WHEN provisional_review.provisional_score >= 0 THEN provisional_review.provisional_score
ELSE NULL
END
WHEN s."initialScore"::double precision >= 0 THEN s."initialScore"::double precision
ELSE NULL
END AS provisional_score,
CASE
WHEN NOT cc.is_completed THEN NULL
WHEN s.status IN (
'FAILED_SCREENING',
'FAILED_REVIEW',
'FAILED_CHECKPOINT_SCREENING',
'FAILED_CHECKPOINT_REVIEW',
'DELETED'
) THEN NULL
WHEN final_review.has_final_review THEN CASE
WHEN final_review."aggregateScore" >= 0 THEN final_review."aggregateScore"
ELSE NULL
END
WHEN s."finalScore"::double precision >= 0 THEN s."finalScore"::double precision
ELSE NULL
END AS final_score_raw,
cc.is_completed,
(
passing_review.is_passing IS TRUE
OR COALESCE(s."finalScore"::double precision, 0) > 98
Expand All @@ -31,7 +59,9 @@ submission_metrics AS (
ON s."challengeId" = cc.id
AND s."memberId" IS NOT NULL
LEFT JOIN LATERAL (
SELECT rs."aggregateScore"
SELECT
TRUE AS has_final_review,
rs."aggregateScore"
FROM reviews."reviewSummation" AS rs
WHERE rs."submissionId" = s.id
AND COALESCE(rs."isFinal", TRUE) = TRUE
Expand All @@ -40,7 +70,9 @@ submission_metrics AS (
LIMIT 1
) AS final_review ON TRUE
LEFT JOIN LATERAL (
SELECT rs."aggregateScore" AS provisional_score
SELECT
TRUE AS has_provisional_review,
rs."aggregateScore" AS provisional_score
FROM reviews."reviewSummation" AS rs
WHERE rs."submissionId" = s.id
AND rs."isProvisional" IS TRUE
Expand Down Expand Up @@ -90,9 +122,12 @@ mm_latest_submission_scores AS (
vsm."memberId",
vsm.provisional_score AS provisional_score_raw,
vsm.final_score_raw,
COALESCE(vsm.final_score_raw, vsm.provisional_score) AS effective_score_raw,
vsm.is_completed,
vsm.submission_timestamp
FROM valid_submission_metrics AS vsm
WHERE
vsm.provisional_score IS NOT NULL
OR vsm.final_score_raw IS NOT NULL
ORDER BY
vsm."memberId",
vsm.submission_timestamp DESC NULLS LAST,
Expand All @@ -110,13 +145,13 @@ mm_ranked_scores AS (
ELSE ROUND(mlss.final_score_raw::numeric, 2)
END AS "finalScore",
CASE
WHEN mlss.effective_score_raw IS NULL THEN NULL
ELSE ROW_NUMBER() OVER (
WHEN mlss.is_completed AND mlss.final_score_raw IS NOT NULL THEN ROW_NUMBER() OVER (
ORDER BY
mlss.effective_score_raw DESC NULLS LAST,
mlss.final_score_raw DESC NULLS LAST,
mlss.submission_timestamp ASC NULLS LAST,
mlss."memberId" ASC
)
ELSE NULL
END AS "finalRank"
FROM mm_latest_submission_scores AS mlss
)
Expand Down Expand Up @@ -194,6 +229,10 @@ ORDER BY
WHEN vsm.is_marathon_match THEN mrs."finalRank"
ELSE NULL
END ASC NULLS LAST,
CASE
WHEN vsm.is_marathon_match AND mrs."finalRank" IS NULL THEN mrs."provisionalScore"
ELSE NULL
END DESC NULLS LAST,
CASE
WHEN vsm.is_marathon_match THEN NULL
ELSE sms."submissionScore"
Expand Down
53 changes: 44 additions & 9 deletions sql/reports/challenges/winners.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
WITH challenge_context AS (
SELECT
c.id,
(ct.name = 'Marathon Match') AS is_marathon_match
(ct.name = 'Marathon Match') AS is_marathon_match,
(c.status = 'COMPLETED') AS is_completed
FROM challenges."Challenge" AS c
JOIN challenges."ChallengeType" AS ct
ON ct.id = c."typeId"
Expand All @@ -15,17 +16,45 @@ submission_metrics AS (
s."finalScore"::double precision,
s."initialScore"::double precision
) AS standard_score,
provisional_review.provisional_score,
COALESCE(
final_review."aggregateScore",
s."finalScore"::double precision
) AS final_score_raw
CASE
WHEN s.status IN (
'FAILED_SCREENING',
'FAILED_REVIEW',
'FAILED_CHECKPOINT_SCREENING',
'FAILED_CHECKPOINT_REVIEW',
'DELETED'
) THEN NULL
WHEN provisional_review.has_provisional_review THEN CASE
WHEN provisional_review.provisional_score >= 0 THEN provisional_review.provisional_score
ELSE NULL
END
WHEN s."initialScore"::double precision >= 0 THEN s."initialScore"::double precision
ELSE NULL
END AS provisional_score,
CASE
WHEN NOT cc.is_completed THEN NULL
WHEN s.status IN (
'FAILED_SCREENING',
'FAILED_REVIEW',
'FAILED_CHECKPOINT_SCREENING',
'FAILED_CHECKPOINT_REVIEW',
'DELETED'
) THEN NULL
WHEN final_review.has_final_review THEN CASE
WHEN final_review."aggregateScore" >= 0 THEN final_review."aggregateScore"
ELSE NULL
END
WHEN s."finalScore"::double precision >= 0 THEN s."finalScore"::double precision
ELSE NULL
END AS final_score_raw
FROM challenge_context AS cc
JOIN reviews."submission" AS s
ON s."challengeId" = cc.id
AND s."memberId" IS NOT NULL
LEFT JOIN LATERAL (
SELECT rs."aggregateScore"
SELECT
TRUE AS has_final_review,
rs."aggregateScore"
FROM reviews."reviewSummation" AS rs
WHERE rs."submissionId" = s.id
AND COALESCE(rs."isFinal", TRUE) = TRUE
Expand All @@ -34,15 +63,20 @@ submission_metrics AS (
LIMIT 1
) AS final_review ON TRUE
LEFT JOIN LATERAL (
SELECT MAX(rs."aggregateScore") AS provisional_score
SELECT
TRUE AS has_provisional_review,
rs."aggregateScore" AS provisional_score
FROM reviews."reviewSummation" AS rs
WHERE rs."submissionId" = s.id
AND rs."isProvisional" IS TRUE
ORDER BY COALESCE(rs."reviewedDate", rs."createdAt") DESC NULLS LAST, rs.id DESC
LIMIT 1
) AS provisional_review ON TRUE
),
winner_members AS MATERIALIZED (
SELECT
cc.is_marathon_match,
cc.is_completed,
cw."userId"::text AS "memberId",
MAX(cw.handle) AS "winnerHandle",
MIN(cw.placement) AS placement
Expand All @@ -52,6 +86,7 @@ winner_members AS MATERIALIZED (
AND cw.type = 'PLACEMENT'
GROUP BY
cc.is_marathon_match,
cc.is_completed,
cw."userId"
),
standard_member_scores AS (
Expand Down Expand Up @@ -126,7 +161,7 @@ SELECT
ELSE NULL
END AS "finalScore",
CASE
WHEN wm.is_marathon_match THEN wm.placement
WHEN wm.is_marathon_match AND wm.is_completed THEN wm.placement
ELSE NULL
END AS "finalRank"
FROM winner_members AS wm
Expand Down
Loading
Loading