Skip to content

PM-4988: Hide project detail editing for copilots#1799

Merged
jmgasper merged 1 commit into
devfrom
PM-4988
May 4, 2026
Merged

PM-4988: Hide project detail editing for copilots#1799
jmgasper merged 1 commit into
devfrom
PM-4988

Conversation

@jmgasper

@jmgasper jmgasper commented May 4, 2026

Copy link
Copy Markdown
Collaborator

What was broken
The Work app used broader project management access for project detail editing, so copilot project members could see edit links and open the project editor for projects where they had copilot access.

Root cause
The existing helper intentionally allows copilot membership for general project write flows, but project detail editing needs a narrower Full Access check.

What was changed
Added a project-detail edit helper that requires admin access or manager-tier user access plus Full Access project membership. Updated the projects list edit affordance and project editor route guard to use the narrower helper while leaving other copilot write flows on the existing helper.

Any added/updated tests
Added permission utility coverage for Full Access project detail edits, including denial for copilot project membership and allowance for admins.

Validation run:

  • PASS: yarn test:no-watch src/apps/work/src/lib/utils/permissions.utils.spec.ts
  • PASS: yarn lint
  • PASS: yarn run build
  • FAIL: yarn test:no-watch currently fails in src/apps/wallet-admin/src/lib/components/payment-view/PaymentView.spec.tsx because the test expects a task project link to use the challenge URL while the component renders the project URL.

What was broken
The Work app used the broader project management access helper for project detail editing, so copilot project members could see edit links and open the project editor for projects where they had copilot access.

Root cause
The existing helper intentionally allows copilot membership for general project write flows, but project detail editing needs a narrower Full Access check.

What was changed
Added a project-detail edit helper that requires admin access or manager-tier user access plus Full Access project membership. Updated the projects list edit affordance and project editor route guard to use the narrower helper while leaving other copilot write flows on the existing helper.

Any added/updated tests
Added permission utility coverage for Full Access project detail edits, including denial for copilot project membership and allowance for admins.
@jmgasper jmgasper requested a review from kkartunov as a code owner May 4, 2026 01:05
@jmgasper jmgasper merged commit 2ce2b0f into dev May 4, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant