Conversation
What was broken The Work app used the broader project management access helper for project detail editing, so copilot project members could see edit links and open the project editor for projects where they had copilot access. Root cause The existing helper intentionally allows copilot membership for general project write flows, but project detail editing needs a narrower Full Access check. What was changed Added a project-detail edit helper that requires admin access or manager-tier user access plus Full Access project membership. Updated the projects list edit affordance and project editor route guard to use the narrower helper while leaving other copilot write flows on the existing helper. Any added/updated tests Added permission utility coverage for Full Access project detail edits, including denial for copilot project membership and allowance for admins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Work app used broader project management access for project detail editing, so copilot project members could see edit links and open the project editor for projects where they had copilot access.
Root cause
The existing helper intentionally allows copilot membership for general project write flows, but project detail editing needs a narrower Full Access check.
What was changed
Added a project-detail edit helper that requires admin access or manager-tier user access plus Full Access project membership. Updated the projects list edit affordance and project editor route guard to use the narrower helper while leaving other copilot write flows on the existing helper.
Any added/updated tests
Added permission utility coverage for Full Access project detail edits, including denial for copilot project membership and allowance for admins.
Validation run: