PM-4992 Update talent search view#1795
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const clearAllFilters = useCallback((): void => { | ||
| searchGenerationRef.current += 1 | ||
| setSelectedCountries([]) | ||
| setOnlyProfileComplete(true) | ||
| setOnlyProfileComplete(false) | ||
| setOnlyOpenToWork(true) | ||
| setOnlyActive(true) | ||
| setSortBy('alphabetical') | ||
| setSelectedSkills([]) | ||
| setHasSearched(true) | ||
| setErrorMessage('') | ||
| skipNextAutoSearchRef.current = true | ||
| setLastSearchedDescription('') | ||
| runMemberSearch([], { | ||
| countries: [], | ||
| generation: searchGenerationRef.current, | ||
| openToWork: true, | ||
| page: 1, | ||
| profileComplete: true, | ||
| recentlyActive: true, | ||
| }) | ||
| }, [runMemberSearch]) | ||
| }, []) |
There was a problem hiding this comment.
🔴 clearAllFilters does not reset results state, leaving stale results displayed with no way to dismiss them
After a successful search, clicking "Clear Filters" calls clearAllFilters which resets filter inputs (skills, countries, toggles) but does not reset hasSearched, results, totalResults, or lastAppliedSearchSignature. Because shouldShowIntroState is !hasSearched (TalentSearchPage.tsx:75), the results view remains visible showing stale results from the previous search. The user cannot dismiss these results because the Search button is disabled when selectedSkills.length === 0 (TalentSearchPage.tsx:492), and there's no other mechanism to clear or refresh the view.
| const clearAllFilters = useCallback((): void => { | |
| searchGenerationRef.current += 1 | |
| setSelectedCountries([]) | |
| setOnlyProfileComplete(true) | |
| setOnlyProfileComplete(false) | |
| setOnlyOpenToWork(true) | |
| setOnlyActive(true) | |
| setSortBy('alphabetical') | |
| setSelectedSkills([]) | |
| setHasSearched(true) | |
| setErrorMessage('') | |
| skipNextAutoSearchRef.current = true | |
| setLastSearchedDescription('') | |
| runMemberSearch([], { | |
| countries: [], | |
| generation: searchGenerationRef.current, | |
| openToWork: true, | |
| page: 1, | |
| profileComplete: true, | |
| recentlyActive: true, | |
| }) | |
| }, [runMemberSearch]) | |
| }, []) | |
| const clearAllFilters = useCallback((): void => { | |
| setSelectedCountries([]) | |
| setOnlyProfileComplete(false) | |
| setOnlyOpenToWork(true) | |
| setOnlyActive(true) | |
| setSelectedSkills([]) | |
| setErrorMessage('') | |
| setLastSearchedDescription('') | |
| setHasSearched(false) | |
| setResults([]) | |
| setTotalResults(0) | |
| setLastAppliedSearchSignature('') | |
| }, []) |
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
This is intended
1 participant
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-4992
What's in this PR?