Conversation
What was broken Direct phase updates could include both an explicit scheduledEndDate and a stale duration. The stale duration won, recalculating the end date and causing active challenge edits to be rejected or saved with the wrong duration. Root cause ChallengePhaseService.partiallyUpdateChallengePhase treated any duration in the payload as authoritative before considering a user-selected scheduledEndDate. What was changed When scheduledEndDate is provided, derive duration from the phase start and that explicit end date. Only derive scheduledEndDate from duration when no explicit end date is present. Kept the phase-helper regression fixture dates in the future so current-time validation remains deterministic. Any added/updated tests Added ChallengePhaseService coverage for explicit scheduledEndDate taking precedence over stale duration. Updated the PM-5378 phase-helper regression fixture dates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The previous PM-5378 API fix allowed active Design-track phase shortening and blocked active non-Design shortening, but direct phase updates could still send a user-selected scheduledEndDate together with a stale duration. The stale duration could override the explicit end date and make later active challenge edits fail or save an unintended timeline.
Root cause
ChallengePhaseService.partiallyUpdateChallengePhase treated duration as authoritative whenever it was present. That did not match the Work app behavior where concrete user-selected end dates should supersede template or stale duration values.
What was changed
When scheduledEndDate is provided, the API now recalculates duration from the phase start and that explicit end date. It only recalculates scheduledEndDate from duration when no explicit end date is supplied. The existing PM-5378 phase-helper regression fixture was also moved into the future so current-time validation remains deterministic.
Any added/updated tests
Added ChallengePhaseService coverage for explicit scheduledEndDate taking precedence over stale duration. Updated phase-helper PM-5378 regression dates.