Skip to content

feat: normalize local song search - #44

Open
Baltsat wants to merge 1 commit into
tonygoldcrest:mainfrom
Baltsat:codex/normalized-local-search
Open

feat: normalize local song search#44
Baltsat wants to merge 1 commit into
tonygoldcrest:mainfrom
Baltsat:codex/normalized-local-search

Conversation

@Baltsat

@Baltsat Baltsat commented Jul 28, 2026

Copy link
Copy Markdown

Summary

  • normalize local search text with Unicode decomposition, diacritic folding, case folding, whitespace normalization, and trimming
  • search name, artist, album, and charter metadata
  • rank exact, prefix, and substring matches ahead of fuzzy matches while preserving stable source order

This is the search portion of #42, split into a standalone PR at the maintainer's request. It applies directly to main and does not depend on the import feature.

Proof

  • 46 focused search and view tests passed
  • full suite passed: 56 files / 685 tests
  • lint passed
  • TypeScript typecheck passed
  • application build passed
  • 3/3 Electron E2E tests passed, including normalized album and charter queries
  • production-hunk revert made the focused regression fail; restoring the final tree returned it to 46/46

AI assistance: I used Codex during implementation and test iteration, then reviewed the final diff and proof.

User-Request: split SightKick tonygoldcrest#42 into independently reviewable features | codex:oss-maintainer-campaign
Signed-off-by: Konstantin Baltsat <baltsat2002@mail.ru>
Copilot AI review requested due to automatic review settings July 28, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tonygoldcrest

Copy link
Copy Markdown
Owner

LGTM. I'll merge after releasing the next version (probably tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants