Clarify nolint comment placement in error messages#9
Merged
Conversation
Add "to this line" to nolint suppression hints so users know exactly which line needs the //nolint:spantool comment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//nolint:spantoolコメントを付ければよいか明示するようにした設計の背景
エラーメッセージの報告行と nolint の検出行は一致しているが、ユーザーにはそれが自明でなかった。
メッセージ末尾に「to this line」を付与するだけで解消できるため、最小限の変更で対応した。
Test plan
go test ./...が通ること（既存テストはstrings.Containsでチェックしているため影響なし）🤖 Generated with Claude Code