Add -no-star flag to lint-scan to forbid SELECT * usage#6
Merged
Conversation
Add Severity to Diagnostic so lint-scan can emit warnings for SELECT * queries that skip validation. With -no-star flag, SELECT * is reported as an error instead. This also moves the hasStar check before analyzeFuncBody to avoid unnecessary callback analysis. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-no-starフラグを追加。指定時はSELECT */SELECT t.*をエラーとして報告-no-star未指定時もSELECT *によるバリデーションスキップを warning として stderr に出力(従来はサイレントスキップ)hasStarチェックをanalyzeFuncBodyの前に移動し、スキップ時の不要なコールバック解析を回避設計の背景
従来
SELECT *は DDL なしではカラム数を確定できないためサイレントにスキップされていた。しかしユーザーがスキップされていることに気づけない問題があったため、2段階のアプローチを採用した:-no-starフラグ:SELECT *自体を禁止するルールとしてエラー報告検討した代替案
-no-starフラグのみ追加する案: ユーザーがフラグの存在を知らないとスキップに気づけないため不採用Test plan
go test ./...全テスト通過SELECT */SELECT t.*/SELECT a, *の各パターンで-no-star時にエラー検出-no-star未指定時に warning が返ること-no-starが影響しないこと🤖 Generated with Claude Code